| Message ID | 20240529-md-apparmor_policy_unpack_test-v1-1-9efc582078c4@quicinc.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | apparmor: test: add MODULE_DESCRIPTION() | expand |
On 5/29/2024 6:21 PM, Jeff Johnson wrote: > Fix the 'make W=1' warning: > WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > security/apparmor/policy_unpack_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c > index 5c9bde25e56d..874fcf97794e 100644 > --- a/security/apparmor/policy_unpack_test.c > +++ b/security/apparmor/policy_unpack_test.c > @@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = { > > kunit_test_suite(apparmor_policy_unpack_test_module); > > +MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack"); > MODULE_LICENSE("GPL"); > > --- > base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358 > change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591 > Following up to see if anything else is needed to get this merged.
On 5/29/24 18:21, Jeff Johnson wrote: > Fix the 'make W=1' warning: > WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Acked-by: John Johansen <john.johansen@canonical.com> I will pull this into my tree > --- > security/apparmor/policy_unpack_test.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c > index 5c9bde25e56d..874fcf97794e 100644 > --- a/security/apparmor/policy_unpack_test.c > +++ b/security/apparmor/policy_unpack_test.c > @@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = { > > kunit_test_suite(apparmor_policy_unpack_test_module); > > +MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack"); > MODULE_LICENSE("GPL"); > > --- > base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358 > change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591 >
On 6/20/24 09:21, Jeff Johnson wrote: > On 5/29/2024 6:21 PM, Jeff Johnson wrote: >> Fix the 'make W=1' warning: >> WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> >> --- >> security/apparmor/policy_unpack_test.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c >> index 5c9bde25e56d..874fcf97794e 100644 >> --- a/security/apparmor/policy_unpack_test.c >> +++ b/security/apparmor/policy_unpack_test.c >> @@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = { >> >> kunit_test_suite(apparmor_policy_unpack_test_module); >> >> +MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack"); >> MODULE_LICENSE("GPL"); >> >> --- >> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358 >> change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591 >> > > Following up to see if anything else is needed to get this merged. sorry, just me catching up on my backlog
On 6/25/24 01:26, John Johansen wrote: > On 5/29/24 18:21, Jeff Johnson wrote: >> Fix the 'make W=1' warning: >> WARNING: modpost: missing MODULE_DESCRIPTION() in >> security/apparmor/apparmor_policy_unpack_test.o >> >> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > > Acked-by: John Johansen <john.johansen@canonical.com> > > I will pull this into my tree I still don't see this in linux-next. I'm hoping to have these warnings fixed tree-wide in 6.11.
diff --git a/security/apparmor/policy_unpack_test.c b/security/apparmor/policy_unpack_test.c index 5c9bde25e56d..874fcf97794e 100644 --- a/security/apparmor/policy_unpack_test.c +++ b/security/apparmor/policy_unpack_test.c @@ -604,4 +604,5 @@ static struct kunit_suite apparmor_policy_unpack_test_module = { kunit_test_suite(apparmor_policy_unpack_test_module); +MODULE_DESCRIPTION("KUnit tests for AppArmor's policy unpack"); MODULE_LICENSE("GPL");
Fix the 'make W=1' warning: WARNING: modpost: missing MODULE_DESCRIPTION() in security/apparmor/apparmor_policy_unpack_test.o Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- security/apparmor/policy_unpack_test.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358 change-id: 20240529-md-apparmor_policy_unpack_test-7657c4f11591