mbox series

[v2,0/7] ROHM BU27034NUC to ROHM BU27034ANUC

Message ID cover.1720176341.git.mazziesaccount@gmail.com (mailing list archive)
Headers show
Series ROHM BU27034NUC to ROHM BU27034ANUC | expand

Message

Matti Vaittinen July 5, 2024, 10:53 a.m. UTC
As discussed here:
https://lore.kernel.org/all/ff8d6d14-6b48-4347-8525-e05eeb9721ff@gmail.com/

The ROHM BU27034NUC was cancelled before it entered mass-production. A
replacement was developed and named to BU27034ANUC. (Note the added
'A' in the model name). The BU27034ANUC has several changes that make
the old BU27034NUC driver unusable with it. I was told the old BU27034NUC
should not be encountered anywhere.

Hence, this series converts the rohm-bu27034.c to support the new
BU27034ANUC instead of the obsoleted BU27034NUC. Additionally, the
series adds a read-only entry for the HARDWAREGAIN to help understanding
what part of the scale is contributed by the gain, and what by the
integration time. This is useful when figuring out why some transitions
from one 'scale' to other are failing.

Revision history:
	v1 => v2:
		- Split the one large patch to patches 3 - 6 for easier
		  review. (Please let me know if you wish me to squash
		  them to one).
		- Introduce new compatible for the BU27034ANUC and drop
		  the old one.
		- Add styling fixes as suggested by Jonathan
		- Fix the lux calculation coefficient selection logic
	link to v1:
		https://lore.kernel.org/all/cover.1718013518.git.mazziesaccount@gmail.com/

---

Matti Vaittinen (7):
  dt-bindings: iio: BU27034 => BU27034ANUC
  dt-bindings: iio: rename bu27034 file
  bu27034: ROHM BU27034NUC to BU27034ANUC
  bu27034: ROHM BU27034NUC to BU27034ANUC drop data2
  bu27034: ROHM BU27034ANUC correct gains and times
  bu27034: ROHM BU27034ANUC correct lux calculation
  iio: bu27034: Add a read only HWARDWAREGAIN

 ...ohm,bu27034.yaml => rohm,bu27034anuc.yaml} |  11 +-
 drivers/iio/light/rohm-bu27034.c              | 343 +++++-------------
 2 files changed, 89 insertions(+), 265 deletions(-)
 rename Documentation/devicetree/bindings/iio/light/{rohm,bu27034.yaml => rohm,bu27034anuc.yaml} (66%)


base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0

Comments

Jonathan Cameron July 13, 2024, 11:01 a.m. UTC | #1
On Fri, 5 Jul 2024 13:53:35 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> As discussed here:
> https://lore.kernel.org/all/ff8d6d14-6b48-4347-8525-e05eeb9721ff@gmail.com/
> 
> The ROHM BU27034NUC was cancelled before it entered mass-production. A
> replacement was developed and named to BU27034ANUC. (Note the added
> 'A' in the model name). The BU27034ANUC has several changes that make
> the old BU27034NUC driver unusable with it. I was told the old BU27034NUC
> should not be encountered anywhere.
> 
> Hence, this series converts the rohm-bu27034.c to support the new
> BU27034ANUC instead of the obsoleted BU27034NUC. Additionally, the
> series adds a read-only entry for the HARDWAREGAIN to help understanding
> what part of the scale is contributed by the gain, and what by the
> integration time. This is useful when figuring out why some transitions
> from one 'scale' to other are failing.
Series applied with that tweak to fix the typo that is getting moved in patch 1
and to squash the first 2 patches.

Applied for now only to the testing branch of iio.git which will become
togreg after I can rebase on rc1.

Thanks,

Jonathan

> 
> Revision history:
> 	v1 => v2:
> 		- Split the one large patch to patches 3 - 6 for easier
> 		  review. (Please let me know if you wish me to squash
> 		  them to one).
> 		- Introduce new compatible for the BU27034ANUC and drop
> 		  the old one.
> 		- Add styling fixes as suggested by Jonathan
> 		- Fix the lux calculation coefficient selection logic
> 	link to v1:
> 		https://lore.kernel.org/all/cover.1718013518.git.mazziesaccount@gmail.com/
> 
> ---
> 
> Matti Vaittinen (7):
>   dt-bindings: iio: BU27034 => BU27034ANUC
>   dt-bindings: iio: rename bu27034 file
>   bu27034: ROHM BU27034NUC to BU27034ANUC
>   bu27034: ROHM BU27034NUC to BU27034ANUC drop data2
>   bu27034: ROHM BU27034ANUC correct gains and times
>   bu27034: ROHM BU27034ANUC correct lux calculation
>   iio: bu27034: Add a read only HWARDWAREGAIN
> 
>  ...ohm,bu27034.yaml => rohm,bu27034anuc.yaml} |  11 +-
>  drivers/iio/light/rohm-bu27034.c              | 343 +++++-------------
>  2 files changed, 89 insertions(+), 265 deletions(-)
>  rename Documentation/devicetree/bindings/iio/light/{rohm,bu27034.yaml => rohm,bu27034anuc.yaml} (66%)
> 
> 
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0