diff mbox series

qcom: move signed x1e80100 signed firmware to the SoC subdir

Message ID 20240715122500.3115456-1-dmitry.baryshkov@linaro.org (mailing list archive)
State Not Applicable
Headers show
Series qcom: move signed x1e80100 signed firmware to the SoC subdir | expand

Commit Message

Dmitry Baryshkov July 15, 2024, 12:25 p.m. UTC
The ZAP shader is signed and is specific for the particular SoC. As such
it should be put the corresponding subdir rather than the topdir.

Move it to the subdir (like all other zap.mbn files).

Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 WHENCE                               |   2 +-
 qcom/{ => x1e80100}/gen70500_zap.mbn | Bin
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename qcom/{ => x1e80100}/gen70500_zap.mbn (100%)

Comments

Josh Boyer July 15, 2024, 1:47 p.m. UTC | #1
On Mon, Jul 15, 2024 at 8:25 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> The ZAP shader is signed and is specific for the particular SoC. As such
> it should be put the corresponding subdir rather than the topdir.
>
> Move it to the subdir (like all other zap.mbn files).
>
> Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Merged and pushed out.

https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/251

josh

> ---
>  WHENCE                               |   2 +-
>  qcom/{ => x1e80100}/gen70500_zap.mbn | Bin
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename qcom/{ => x1e80100}/gen70500_zap.mbn (100%)
>
> diff --git a/WHENCE b/WHENCE
> index e4e06b966e89..b6451372a6ef 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -5992,7 +5992,7 @@ File: qcom/leia_pm4_470.fw
>  File: qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn
>  File: qcom/gen70500_gmu.bin
>  File: qcom/gen70500_sqe.fw
> -File: qcom/gen70500_zap.mbn
> +File: qcom/x1e80100/gen70500_zap.mbn
>
>  Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
>
> diff --git a/qcom/gen70500_zap.mbn b/qcom/x1e80100/gen70500_zap.mbn
> similarity index 100%
> rename from qcom/gen70500_zap.mbn
> rename to qcom/x1e80100/gen70500_zap.mbn
> --
> 2.43.0
>
Akhil P Oommen July 15, 2024, 2:03 p.m. UTC | #2
On Mon, Jul 15, 2024 at 03:25:00PM +0300, Dmitry Baryshkov wrote:
> The ZAP shader is signed and is specific for the particular SoC. As such
> it should be put the corresponding subdir rather than the topdir.
> 
> Move it to the subdir (like all other zap.mbn files).

This need a similar change in x1e devicetree too, right? Are you
planning to send that?

-Akhil

> 
> Cc: Akhil P Oommen <quic_akhilpo@quicinc.com>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  WHENCE                               |   2 +-
>  qcom/{ => x1e80100}/gen70500_zap.mbn | Bin
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename qcom/{ => x1e80100}/gen70500_zap.mbn (100%)
> 
> diff --git a/WHENCE b/WHENCE
> index e4e06b966e89..b6451372a6ef 100644
> --- a/WHENCE
> +++ b/WHENCE
> @@ -5992,7 +5992,7 @@ File: qcom/leia_pm4_470.fw
>  File: qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn
>  File: qcom/gen70500_gmu.bin
>  File: qcom/gen70500_sqe.fw
> -File: qcom/gen70500_zap.mbn
> +File: qcom/x1e80100/gen70500_zap.mbn
>  
>  Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
>  
> diff --git a/qcom/gen70500_zap.mbn b/qcom/x1e80100/gen70500_zap.mbn
> similarity index 100%
> rename from qcom/gen70500_zap.mbn
> rename to qcom/x1e80100/gen70500_zap.mbn
> -- 
> 2.43.0
>
Dmitry Baryshkov July 15, 2024, 2:15 p.m. UTC | #3
On Mon, 15 Jul 2024 at 17:04, Akhil P Oommen <quic_akhilpo@quicinc.com> wrote:
>
> On Mon, Jul 15, 2024 at 03:25:00PM +0300, Dmitry Baryshkov wrote:
> > The ZAP shader is signed and is specific for the particular SoC. As such
> > it should be put the corresponding subdir rather than the topdir.
> >
> > Move it to the subdir (like all other zap.mbn files).
>
> This need a similar change in x1e devicetree too, right? Are you
> planning to send that?

Why was the firmware name incorporated into the x1e80100.dtsi? Yes, it
needs to be dropped.
diff mbox series

Patch

diff --git a/WHENCE b/WHENCE
index e4e06b966e89..b6451372a6ef 100644
--- a/WHENCE
+++ b/WHENCE
@@ -5992,7 +5992,7 @@  File: qcom/leia_pm4_470.fw
 File: qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn
 File: qcom/gen70500_gmu.bin
 File: qcom/gen70500_sqe.fw
-File: qcom/gen70500_zap.mbn
+File: qcom/x1e80100/gen70500_zap.mbn
 
 Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details
 
diff --git a/qcom/gen70500_zap.mbn b/qcom/x1e80100/gen70500_zap.mbn
similarity index 100%
rename from qcom/gen70500_zap.mbn
rename to qcom/x1e80100/gen70500_zap.mbn