| Message ID | 20240715-pci-qcom-hotplug-v1-4-5f3765cc873a@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | PCI: qcom: Simulate PCIe hotplug using 'global' interrupt | expand |
On 15.07.2024 7:33 PM, Manivannan Sadhasivam via B4 Relay wrote: > From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > 'linux,pci-domain' property provides the PCI domain number for the PCI > endpoint controllers in a SoC. If this property is not present, then an > unstable (across boots) unique number will be assigned. > > Devicetrees can specify the domain number based on the actual hardware > instance of the PCI endpoint controllers in the SoC. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- Hm, perhaps pci-controller-common.yaml could make sense here? Konrad
On Mon, Jul 15, 2024 at 09:59:12PM +0200, Konrad Dybcio wrote: > On 15.07.2024 7:33 PM, Manivannan Sadhasivam via B4 Relay wrote: > > From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > > > 'linux,pci-domain' property provides the PCI domain number for the PCI > > endpoint controllers in a SoC. If this property is not present, then an > > unstable (across boots) unique number will be assigned. > > > > Devicetrees can specify the domain number based on the actual hardware > > instance of the PCI endpoint controllers in the SoC. > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > Hm, perhaps pci-controller-common.yaml could make sense here? > For RC, this property is defined in 'pci-host-bridge.yaml' which is hosted in dtschema repo. And the description of this property varies between host and endpoint, so we cannot use a common one. TBH, endpoint doesn't really need _this_ property as there is no PCIe domain here. But I used this one since it already exist and does the job pretty well. - Mani
On Mon, Jul 15, 2024 at 11:03:46PM +0530, Manivannan Sadhasivam wrote: > 'linux,pci-domain' property provides the PCI domain number for the PCI > endpoint controllers in a SoC. If this property is not present, then an > unstable (across boots) unique number will be assigned. > > Devicetrees can specify the domain number based on the actual hardware > instance of the PCI endpoint controllers in the SoC. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > Documentation/devicetree/bindings/pci/pci-ep.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/pci/pci-ep.yaml b/Documentation/devicetree/bindings/pci/pci-ep.yaml index 0b5456ee21eb..f75000e3093d 100644 --- a/Documentation/devicetree/bindings/pci/pci-ep.yaml +++ b/Documentation/devicetree/bindings/pci/pci-ep.yaml @@ -42,6 +42,17 @@ properties: default: 1 maximum: 16 + linux,pci-domain: + description: + If present this property assigns a fixed PCI domain number to a PCI + Endpoint Controller, otherwise an unstable (across boots) unique number + will be assigned. It is required to either not set this property at all + or set it for all PCI endpoint controllers in the system, otherwise + potentially conflicting domain numbers may be assigned to endpoint + controllers. The domain number for each endpoint controller in the system + must be unique. + $ref: /schemas/types.yaml#/definitions/uint32 + required: - compatible