| Message ID | 20240705103614.3650637-1-quic_zhonhan@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion | expand |
On Fri, 05 Jul 2024 18:36:14 +0800, Zhongqiu Han wrote: > The _ONSTACK variant should be used for on-stack completion, otherwise it > will break lockdep. See also commit 6e9a4738c9fa ("[PATCH] completions: > lockdep annotate on stack completions"). > > Applied to 6.11/scsi-queue, thanks! [1/1] scsi: aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion https://git.kernel.org/mkp/scsi/c/23cef42d1741
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c index 83f16fc14d96..a0fb330b8df5 100644 --- a/drivers/scsi/aha152x.c +++ b/drivers/scsi/aha152x.c @@ -1072,7 +1072,7 @@ static int aha152x_abort(struct scsi_cmnd *SCpnt) static int aha152x_device_reset(struct scsi_cmnd * SCpnt) { struct Scsi_Host *shpnt = SCpnt->device->host; - DECLARE_COMPLETION(done); + DECLARE_COMPLETION_ONSTACK(done); int ret, issued, disconnected; unsigned char old_cmd_len = SCpnt->cmd_len; unsigned long flags;
The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. See also commit 6e9a4738c9fa ("[PATCH] completions: lockdep annotate on stack completions"). Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com> --- drivers/scsi/aha152x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)