mbox series

[0/6] mfd: add adp5585 gpio and pwm support

Message ID 20240716-adi-v1-0-79c0122986e7@nxp.com (mailing list archive)
Headers show
Series mfd: add adp5585 gpio and pwm support | expand

Message

Frank Li July 16, 2024, 7:28 p.m. UTC
adp5585 is totally difference adp5588, which in
drivers/input/keyboard/adp5588-keys.c.

So create new driver for it.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Clark Wang (1):
      pwm: adp5585: add adp5585 PWM support

Frank Li (3):
      dt-bindings: mfd: Add i2c device adi5585
      arm64: dts: imx93-11x11-evk: add adi,adp5585 gpio and pwm
      arm64: dts: imx95-19x19-evk: add i2c2 and adi,adp5585

Haibo Chen (2):
      mfd: adp5585: add ADI adp5585 core support
      gpio: adp5585-gpio: add adp5585-gpio support

 .../devicetree/bindings/mfd/adi,adp5585.yaml       |  83 ++++++++
 arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts  |  16 ++
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts  |  30 +++
 drivers/gpio/Kconfig                               |   7 +
 drivers/gpio/Makefile                              |   1 +
 drivers/gpio/gpio-adp5585.c                        | 184 ++++++++++++++++++
 drivers/mfd/Kconfig                                |   9 +
 drivers/mfd/Makefile                               |   1 +
 drivers/mfd/adp5585.c                              | 134 +++++++++++++
 drivers/pwm/Kconfig                                |   8 +
 drivers/pwm/Makefile                               |   1 +
 drivers/pwm/pwm-adp5585.c                          | 215 +++++++++++++++++++++
 include/linux/mfd/adp5585.h                        | 100 ++++++++++
 13 files changed, 789 insertions(+)
---
base-commit: 91e3b24eb7d297d9d99030800ed96944b8652eaf
change-id: 20240715-adi-11ff2d3d35ec

Best regards,
---
Frank Li <Frank.Li@nxp.com>

Comments

Rob Herring July 16, 2024, 9:12 p.m. UTC | #1
On Tue, 16 Jul 2024 15:28:23 -0400, Frank Li wrote:
> adp5585 is totally difference adp5588, which in
> drivers/input/keyboard/adp5588-keys.c.
> 
> So create new driver for it.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Clark Wang (1):
>       pwm: adp5585: add adp5585 PWM support
> 
> Frank Li (3):
>       dt-bindings: mfd: Add i2c device adi5585
>       arm64: dts: imx93-11x11-evk: add adi,adp5585 gpio and pwm
>       arm64: dts: imx95-19x19-evk: add i2c2 and adi,adp5585
> 
> Haibo Chen (2):
>       mfd: adp5585: add ADI adp5585 core support
>       gpio: adp5585-gpio: add adp5585-gpio support
> 
>  .../devicetree/bindings/mfd/adi,adp5585.yaml       |  83 ++++++++
>  arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts  |  16 ++
>  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts  |  30 +++
>  drivers/gpio/Kconfig                               |   7 +
>  drivers/gpio/Makefile                              |   1 +
>  drivers/gpio/gpio-adp5585.c                        | 184 ++++++++++++++++++
>  drivers/mfd/Kconfig                                |   9 +
>  drivers/mfd/Makefile                               |   1 +
>  drivers/mfd/adp5585.c                              | 134 +++++++++++++
>  drivers/pwm/Kconfig                                |   8 +
>  drivers/pwm/Makefile                               |   1 +
>  drivers/pwm/pwm-adp5585.c                          | 215 +++++++++++++++++++++
>  include/linux/mfd/adp5585.h                        | 100 ++++++++++
>  13 files changed, 789 insertions(+)
> ---
> base-commit: 91e3b24eb7d297d9d99030800ed96944b8652eaf
> change-id: 20240715-adi-11ff2d3d35ec
> 
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y freescale/imx93-11x11-evk.dtb freescale/imx95-19x19-evk.dtb' for 20240716-adi-v1-0-79c0122986e7@nxp.com:

arch/arm64/boot/dts/freescale/imx93-11x11-evk.dtb: mfd@34: 'gpio', 'pwm' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
arch/arm64/boot/dts/freescale/imx95-19x19-evk.dtb: mfd@34: 'gpio-adp5585', 'pwm-adp5585' do not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
Krzysztof Kozlowski July 17, 2024, 6:59 a.m. UTC | #2
On 16/07/2024 21:28, Frank Li wrote:
> adp5585 is totally difference adp5588, which in
> drivers/input/keyboard/adp5588-keys.c.
> 
> So create new driver for it.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

There is ongoing work (v4 if I recall) for adp5585, so please rebase on
that. Existing patches do not look abandoned.

Best regards,
Krzysztof