mbox series

[v2,0/9] reset: amlogic: move audio reset drivers out of CCF

Message ID 20240718095755.3511992-1-jbrunet@baylibre.com (mailing list archive)
Headers show
Series reset: amlogic: move audio reset drivers out of CCF | expand

Message

Jerome Brunet July 18, 2024, 9:57 a.m. UTC 
This patchset follows the discussion about having reset driver in the
clock tree [1]. Ideally those should reside in the reset part of tree.

Also the code of the amlogic reset driver is very similar between the 2
trees and could use the same driver code.

This patcheset alignes the reset drivers present in the reset and clock
then adds support for the reset driver of audio clock controller found in
the  g12 and sm1 SoC family to the reset tree, using the auxiliary bus.

The infrastructure put in place is meant to be generic enough so we may
eventually also move the reset drivers in the meson8b and aoclk clock
controllers.

Changes since v1 [3]:
 * Fixes formatting errors reported by Stephen.
 * Changed parameters type to unsigned
 * Fix usage of ops passed as parameters, previously ignored.
 * Return 0 instead of an error if reset support is absent
   to properly decouple from the clock and have a weak
   dependency
 * Split the platform and auxiliary modules in 2 distinct modules
   to fix the COMPILE_TEST error reported by ktest robot.

Change since RFC [2]:
 * Move the aux registration helper out of clock too.

[1] https://lore.kernel.org/linux-clk/e3a85852b911fdf16dd9ae158f42b3ef.sboyd@kernel.org
[2] https://lore.kernel.org/linux-clk/20240516150842.705844-1-jbrunet@baylibre.com
[3] https://lore.kernel.org/linux-clk/20240710162526.2341399-1-jbrunet@baylibre.com

Jerome Brunet (9):
  reset: amlogic: convert driver to regmap
  reset: amlogic: use generic data matching function
  reset: amlogic: make parameters unsigned
  reset: amlogic: add driver parameters
  reset: amlogic: use reset number instead of register count
  reset: amlogic: add reset status support
  reset: amlogic: move drivers to a dedicated directory
  reset: amlogic: split the device core and platform probe
  reset: amlogic: add auxiliary reset driver support

 drivers/reset/Kconfig                         |  15 +-
 drivers/reset/Makefile                        |   3 +-
 drivers/reset/amlogic/Kconfig                 |  27 ++++
 drivers/reset/amlogic/Makefile                |   4 +
 .../{ => amlogic}/reset-meson-audio-arb.c     |   0
 drivers/reset/amlogic/reset-meson-aux.c       | 136 ++++++++++++++++
 drivers/reset/amlogic/reset-meson-core.c      | 140 ++++++++++++++++
 drivers/reset/amlogic/reset-meson-pltf.c      |  95 +++++++++++
 drivers/reset/amlogic/reset-meson.h           |  28 ++++
 drivers/reset/reset-meson.c                   | 153 ------------------
 include/soc/amlogic/meson-auxiliary-reset.h   |  23 +++
 11 files changed, 455 insertions(+), 169 deletions(-)
 create mode 100644 drivers/reset/amlogic/Kconfig
 create mode 100644 drivers/reset/amlogic/Makefile
 rename drivers/reset/{ => amlogic}/reset-meson-audio-arb.c (100%)
 create mode 100644 drivers/reset/amlogic/reset-meson-aux.c
 create mode 100644 drivers/reset/amlogic/reset-meson-core.c
 create mode 100644 drivers/reset/amlogic/reset-meson-pltf.c
 create mode 100644 drivers/reset/amlogic/reset-meson.h
 delete mode 100644 drivers/reset/reset-meson.c
 create mode 100644 include/soc/amlogic/meson-auxiliary-reset.h

Comments

Jan Dakinevich July 18, 2024, 2:20 p.m. UTC | #1 
In previous series there was a patch "[PATCH 8/8] clk: amlogic:
axg-audio: use the auxiliary reset driver", but I don't see it here. Did
you removed it, or I missed something?


On 7/18/24 12:57, Jerome Brunet wrote:
> This patchset follows the discussion about having reset driver in the
> clock tree [1]. Ideally those should reside in the reset part of tree.
> 
> Also the code of the amlogic reset driver is very similar between the 2
> trees and could use the same driver code.
> 
> This patcheset alignes the reset drivers present in the reset and clock
> then adds support for the reset driver of audio clock controller found in
> the  g12 and sm1 SoC family to the reset tree, using the auxiliary bus.
> 
> The infrastructure put in place is meant to be generic enough so we may
> eventually also move the reset drivers in the meson8b and aoclk clock
> controllers.
> 
> Changes since v1 [3]:
>  * Fixes formatting errors reported by Stephen.
>  * Changed parameters type to unsigned
>  * Fix usage of ops passed as parameters, previously ignored.
>  * Return 0 instead of an error if reset support is absent
>    to properly decouple from the clock and have a weak
>    dependency
>  * Split the platform and auxiliary modules in 2 distinct modules
>    to fix the COMPILE_TEST error reported by ktest robot.
> 
> Change since RFC [2]:
>  * Move the aux registration helper out of clock too.
> 
> [1] https://lore.kernel.org/linux-clk/e3a85852b911fdf16dd9ae158f42b3ef.sboyd@kernel.org
> [2] https://lore.kernel.org/linux-clk/20240516150842.705844-1-jbrunet@baylibre.com
> [3] https://lore.kernel.org/linux-clk/20240710162526.2341399-1-jbrunet@baylibre.com
> 
> Jerome Brunet (9):
>   reset: amlogic: convert driver to regmap
>   reset: amlogic: use generic data matching function
>   reset: amlogic: make parameters unsigned
>   reset: amlogic: add driver parameters
>   reset: amlogic: use reset number instead of register count
>   reset: amlogic: add reset status support
>   reset: amlogic: move drivers to a dedicated directory
>   reset: amlogic: split the device core and platform probe
>   reset: amlogic: add auxiliary reset driver support
> 
>  drivers/reset/Kconfig                         |  15 +-
>  drivers/reset/Makefile                        |   3 +-
>  drivers/reset/amlogic/Kconfig                 |  27 ++++
>  drivers/reset/amlogic/Makefile                |   4 +
>  .../{ => amlogic}/reset-meson-audio-arb.c     |   0
>  drivers/reset/amlogic/reset-meson-aux.c       | 136 ++++++++++++++++
>  drivers/reset/amlogic/reset-meson-core.c      | 140 ++++++++++++++++
>  drivers/reset/amlogic/reset-meson-pltf.c      |  95 +++++++++++
>  drivers/reset/amlogic/reset-meson.h           |  28 ++++
>  drivers/reset/reset-meson.c                   | 153 ------------------
>  include/soc/amlogic/meson-auxiliary-reset.h   |  23 +++
>  11 files changed, 455 insertions(+), 169 deletions(-)
>  create mode 100644 drivers/reset/amlogic/Kconfig
>  create mode 100644 drivers/reset/amlogic/Makefile
>  rename drivers/reset/{ => amlogic}/reset-meson-audio-arb.c (100%)
>  create mode 100644 drivers/reset/amlogic/reset-meson-aux.c
>  create mode 100644 drivers/reset/amlogic/reset-meson-core.c
>  create mode 100644 drivers/reset/amlogic/reset-meson-pltf.c
>  create mode 100644 drivers/reset/amlogic/reset-meson.h
>  delete mode 100644 drivers/reset/reset-meson.c
>  create mode 100644 include/soc/amlogic/meson-auxiliary-reset.h
>
Jerome Brunet July 18, 2024, 5:20 p.m. UTC | #2 
On Thu 18 Jul 2024 at 17:20, Jan Dakinevich <jan.dakinevich@salutedevices.com> wrote:

> In previous series there was a patch "[PATCH 8/8] clk: amlogic:
> axg-audio: use the auxiliary reset driver", but I don't see it here. Did
> you removed it, or I missed something?

It is meant for another tree and will be sent seperately

>
>
> On 7/18/24 12:57, Jerome Brunet wrote:
>> This patchset follows the discussion about having reset driver in the
>> clock tree [1]. Ideally those should reside in the reset part of tree.
>> 
>> Also the code of the amlogic reset driver is very similar between the 2
>> trees and could use the same driver code.
>> 
>> This patcheset alignes the reset drivers present in the reset and clock
>> then adds support for the reset driver of audio clock controller found in
>> the  g12 and sm1 SoC family to the reset tree, using the auxiliary bus.
>> 
>> The infrastructure put in place is meant to be generic enough so we may
>> eventually also move the reset drivers in the meson8b and aoclk clock
>> controllers.
>> 
>> Changes since v1 [3]:
>>  * Fixes formatting errors reported by Stephen.
>>  * Changed parameters type to unsigned
>>  * Fix usage of ops passed as parameters, previously ignored.
>>  * Return 0 instead of an error if reset support is absent
>>    to properly decouple from the clock and have a weak
>>    dependency
>>  * Split the platform and auxiliary modules in 2 distinct modules
>>    to fix the COMPILE_TEST error reported by ktest robot.
>> 
>> Change since RFC [2]:
>>  * Move the aux registration helper out of clock too.
>> 
>> [1] https://lore.kernel.org/linux-clk/e3a85852b911fdf16dd9ae158f42b3ef.sboyd@kernel.org
>> [2] https://lore.kernel.org/linux-clk/20240516150842.705844-1-jbrunet@baylibre.com
>> [3] https://lore.kernel.org/linux-clk/20240710162526.2341399-1-jbrunet@baylibre.com
>> 
>> Jerome Brunet (9):
>>   reset: amlogic: convert driver to regmap
>>   reset: amlogic: use generic data matching function
>>   reset: amlogic: make parameters unsigned
>>   reset: amlogic: add driver parameters
>>   reset: amlogic: use reset number instead of register count
>>   reset: amlogic: add reset status support
>>   reset: amlogic: move drivers to a dedicated directory
>>   reset: amlogic: split the device core and platform probe
>>   reset: amlogic: add auxiliary reset driver support
>> 
>>  drivers/reset/Kconfig                         |  15 +-
>>  drivers/reset/Makefile                        |   3 +-
>>  drivers/reset/amlogic/Kconfig                 |  27 ++++
>>  drivers/reset/amlogic/Makefile                |   4 +
>>  .../{ => amlogic}/reset-meson-audio-arb.c     |   0
>>  drivers/reset/amlogic/reset-meson-aux.c       | 136 ++++++++++++++++
>>  drivers/reset/amlogic/reset-meson-core.c      | 140 ++++++++++++++++
>>  drivers/reset/amlogic/reset-meson-pltf.c      |  95 +++++++++++
>>  drivers/reset/amlogic/reset-meson.h           |  28 ++++
>>  drivers/reset/reset-meson.c                   | 153 ------------------
>>  include/soc/amlogic/meson-auxiliary-reset.h   |  23 +++
>>  11 files changed, 455 insertions(+), 169 deletions(-)
>>  create mode 100644 drivers/reset/amlogic/Kconfig
>>  create mode 100644 drivers/reset/amlogic/Makefile
>>  rename drivers/reset/{ => amlogic}/reset-meson-audio-arb.c (100%)
>>  create mode 100644 drivers/reset/amlogic/reset-meson-aux.c
>>  create mode 100644 drivers/reset/amlogic/reset-meson-core.c
>>  create mode 100644 drivers/reset/amlogic/reset-meson-pltf.c
>>  create mode 100644 drivers/reset/amlogic/reset-meson.h
>>  delete mode 100644 drivers/reset/reset-meson.c
>>  create mode 100644 include/soc/amlogic/meson-auxiliary-reset.h
>>