| Message ID | 20240719111210.1287783-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] dt-bindings: trivial-devices: Document elgin,jg10309-01 | expand |
On Fri, Jul 19, 2024 at 08:12:08AM -0300, Fabio Estevam wrote: > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > The marking on the LCD is JG10309-01. > > Add an entry for the "elgin,jg10309-01" compatible string. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Please send cover letter for patch series. The whole lot seems fine, although ideally this wouldn't be in trivial devices - but I think the series is an improvement on lying about what's on the board ;) Acked-by: Conor Dooley <conor.dooley@microchip.com>
On Fri, 19 Jul 2024 08:12:08 -0300, Fabio Estevam wrote: > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > The marking on the LCD is JG10309-01. > > Add an entry for the "elgin,jg10309-01" compatible string. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > Changes since v1: > - Use a more specific compatible string. (Conor) > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb' for 20240719111210.1287783-1-festevam@gmail.com: arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
Am Freitag, 19. Juli 2024, 16:45:24 CEST schrieb Conor Dooley: > On Fri, Jul 19, 2024 at 08:12:08AM -0300, Fabio Estevam wrote: > > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > > The marking on the LCD is JG10309-01. > > > > Add an entry for the "elgin,jg10309-01" compatible string. > > > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > Please send cover letter for patch series. The whole lot seems fine, > although ideally this wouldn't be in trivial devices - but I think the > series is an improvement on lying about what's on the board ;) > Acked-by: Conor Dooley <conor.dooley@microchip.com> with the error Rob's bot reported about the usage of spi-cpol and spi-cpha, it really looks like the bindings needs to be more fleshed out.
Hi Heiko, On Fri, Jul 26, 2024 at 6:57 PM Heiko Stübner <heiko@sntech.de> wrote: > with the error Rob's bot reported about the usage of spi-cpol and > spi-cpha, it really looks like the bindings needs to be more fleshed out. I just wanted to let you know that the warning reported by Rob's bot is very old. Running "make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml" on the existing tree: DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb rv1108-elgin-r1.dtb: dac@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# So we are not making things worse in this aspect. I can work on removing the warnings as an incremental patch, if you agree. Regards, Fabio Estevam
On Mon, Aug 05, 2024 at 10:18:24AM -0300, Fabio Estevam wrote: > Hi Heiko, > > On Fri, Jul 26, 2024 at 6:57 PM Heiko Stübner <heiko@sntech.de> wrote: > > > with the error Rob's bot reported about the usage of spi-cpol and > > spi-cpha, it really looks like the bindings needs to be more fleshed out. > > I just wanted to let you know that the warning reported by Rob's bot > is very old. > > Running "make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml" on the > existing tree: > > DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb > rv1108-elgin-r1.dtb: dac@0: 'spi-cpha', 'spi-cpol' do not match any of > the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > > So we are not making things worse in this aspect. > > I can work on removing the warnings as an incremental patch, if you agree. Yeah, I acked it cos the issue would've been there before so it's not any worse. I think adding a "real" binding can be a follow on.
Am Freitag, 19. Juli 2024, 13:12:08 CEST schrieb Fabio Estevam: > The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. > The marking on the LCD is JG10309-01. > > Add an entry for the "elgin,jg10309-01" compatible string. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Acked-by: Heiko Stuebner <heiko@sntech.de> > --- > Changes since v1: > - Use a more specific compatible string. (Conor) > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 7913ca9b6b54..49dee2a1f6b4 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -110,6 +110,8 @@ properties: > - domintech,dmard09 > # DMARD10: 3-axis Accelerometer > - domintech,dmard10 > + # Elgin SPI-controlled LCD > + - elgin,jg10309-01 > # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor > - fsl,mma7660 > # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer >
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 7913ca9b6b54..49dee2a1f6b4 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -110,6 +110,8 @@ properties: - domintech,dmard09 # DMARD10: 3-axis Accelerometer - domintech,dmard10 + # Elgin SPI-controlled LCD + - elgin,jg10309-01 # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor - fsl,mma7660 # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
The rv1108-elgin-r1 board has an LCD controlled via SPI in userspace. The marking on the LCD is JG10309-01. Add an entry for the "elgin,jg10309-01" compatible string. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- Changes since v1: - Use a more specific compatible string. (Conor) Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)