diff mbox series

arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

Message ID 20240723131142.1703-1-raymondhackley@protonmail.com (mailing list archive)
State Accepted
Commit ccf683fa0c9b5c53534030ddc9dd8a8603f715a0
Headers show
Series arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys | expand

Commit Message

Raymond Hackley July 23, 2024, 1:12 p.m. UTC
The phone needs the touchkeys to be enabled so the sense lines of the
touch controller are mapped properly. Otherwise the touchscreen is not
mapped to the display properly.

Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
---
 arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Konrad Dybcio July 23, 2024, 1:13 p.m. UTC | #1
On 23.07.2024 3:12 PM, Raymond Hackley wrote:
> The phone needs the touchkeys to be enabled so the sense lines of the
> touch controller are mapped properly. Otherwise the touchscreen is not
> mapped to the display properly.
> 
> Signed-off-by: Raymond Hackley <raymondhackley@protonmail.com>
> ---

Fixes?

Konrad
Raymond Hackley July 23, 2024, 1:39 p.m. UTC | #2
> Fixes?
>
> Konrad

Hi Konrad,

the issue is not reported or discussed on lkml, so there is no thread to fix?

Regards,
Raymond
Konrad Dybcio July 23, 2024, 1:42 p.m. UTC | #3
On 23.07.2024 3:39 PM, Raymond Hackley wrote:
>> Fixes?
>>
>> Konrad
> 
> Hi Konrad,
> 
> the issue is not reported or discussed on lkml, so there is no thread to fix?

See the "In case your patch fixes a bug.." paragraph in:

https://docs.kernel.org/process/submitting-patches.html
> 
> Regards,
> Raymond
>
Raymond Hackley July 24, 2024, 2:26 p.m. UTC | #4
> See the "In case your patch fixes a bug.." paragraph in:
>
> https://docs.kernel.org/process/submitting-patches.html

Hi Konrad,

the point is not to fix a bug, but to add touchkeys support instead.
I will reword the patch when it's confusing.

Regards,
Raymond
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
index 81b3e0760154..7a7e99b015d9 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-fortuna-common.dtsi
@@ -262,6 +262,8 @@  touchscreen: touchscreen@20 {
 
 		pinctrl-0 = <&tsp_int_default>;
 		pinctrl-names = "default";
+
+		linux,keycodes = <KEY_APPSELECT KEY_BACK>;
 	};
 };