| Message ID | 20240723133230.1325392-1-make24@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: typec: ucsi: Fix NULL pointer dereference in ucsi_displayport_vdm() | expand |
Hi Ma Ke, On Tue, Jul 23, 2024 at 09:32:30PM +0800, Ma Ke wrote: > When dp->con->partner is an error, a NULL pointer dereference may occur. > Add a check for dp->con->partner to avoid dereferencing a NULL pointer. > > Fixes: 372adf075a43 ("usb: typec: ucsi: Determine common SVDM Version") > Signed-off-by: Ma Ke <make24@iscas.ac.cn> > --- > drivers/usb/typec/ucsi/displayport.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/typec/ucsi/displayport.c b/drivers/usb/typec/ucsi/displayport.c > index 420af5139c70..eb7d3f97940a 100644 > --- a/drivers/usb/typec/ucsi/displayport.c > +++ b/drivers/usb/typec/ucsi/displayport.c > @@ -222,6 +222,8 @@ static int ucsi_displayport_vdm(struct typec_altmode *alt, > switch (cmd_type) { > case CMDT_INIT: > if (PD_VDO_SVDM_VER(header) < svdm_version) { > + if (IS_ERR_OR_NULL(dp->con->parter)) It looks like you have a typo here. s/parter/partner > + break; > typec_partner_set_svdm_version(dp->con->partner, PD_VDO_SVDM_VER(header)); > svdm_version = PD_VDO_SVDM_VER(header); > } > -- > 2.25.1 >
On Tue, Jul 23, 2024 at 09:32:30PM +0800, Ma Ke wrote: > When dp->con->partner is an error, a NULL pointer dereference may occur. > Add a check for dp->con->partner to avoid dereferencing a NULL pointer. > > Fixes: 372adf075a43 ("usb: typec: ucsi: Determine common SVDM Version") > Signed-off-by: Ma Ke <make24@iscas.ac.cn> > --- > drivers/usb/typec/ucsi/displayport.c | 2 ++ > 1 file changed, 2 insertions(+) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/usb/typec/ucsi/displayport.c b/drivers/usb/typec/ucsi/displayport.c index 420af5139c70..eb7d3f97940a 100644 --- a/drivers/usb/typec/ucsi/displayport.c +++ b/drivers/usb/typec/ucsi/displayport.c @@ -222,6 +222,8 @@ static int ucsi_displayport_vdm(struct typec_altmode *alt, switch (cmd_type) { case CMDT_INIT: if (PD_VDO_SVDM_VER(header) < svdm_version) { + if (IS_ERR_OR_NULL(dp->con->parter)) + break; typec_partner_set_svdm_version(dp->con->partner, PD_VDO_SVDM_VER(header)); svdm_version = PD_VDO_SVDM_VER(header); }
When dp->con->partner is an error, a NULL pointer dereference may occur. Add a check for dp->con->partner to avoid dereferencing a NULL pointer. Fixes: 372adf075a43 ("usb: typec: ucsi: Determine common SVDM Version") Signed-off-by: Ma Ke <make24@iscas.ac.cn> --- drivers/usb/typec/ucsi/displayport.c | 2 ++ 1 file changed, 2 insertions(+)