| Message ID | 20240722123519.333088-1-make24@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] spi: ppc4xx: handle irq_of_parse_and_map() errors | expand |
On Mon, Jul 22, 2024 at 08:35:19PM +0800, Ma Ke wrote: > Zero and negative number is not a valid IRQ for in-kernel code and the > irq_of_parse_and_map() function returns zero on error. So this check for > valid IRQs should only accept values > 0. > > Cc: stable@vger.kernel.org > Fixes: 44dab88e7cc9 ("spi: add spi_ppc4xx driver") > Signed-off-by: Ma Ke <make24@iscas.ac.cn> > --- > Changes in v2: > - added Cc stable line; > - added Fixes line. The Cc stable seems clearly disproportionate here.
> > Zero and negative number is not a valid IRQ for in-kernel code and the > > irq_of_parse_and_map() function returns zero on error. So this check for > > valid IRQs should only accept values > 0. > > > > Cc: stable@vger.kernel.org > > Fixes: 44dab88e7cc9 ("spi: add spi_ppc4xx driver") > > Signed-off-by: Ma Ke <make24@iscas.ac.cn> > > --- > > Changes in v2: > > - added Cc stable line; > > - added Fixes line. > > The Cc stable seems clearly disproportionate here. I wonder a bit about such a feedback (according to a commit from 2009-09-23). Greg Kroah-Hartman configured a patch email bot in other ways. Another example: Re: [PATCH] usb: typec: ucsi: Fix NULL pointer dereference in ucsi_displayport_vdm() https://lore.kernel.org/linux-usb/2024072333-popcorn-detached-f399@gregkh/ Regards, Markus
diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c index 942c3117ab3a..01fdecbf132d 100644 --- a/drivers/spi/spi-ppc4xx.c +++ b/drivers/spi/spi-ppc4xx.c @@ -413,6 +413,9 @@ static int spi_ppc4xx_of_probe(struct platform_device *op) /* Request IRQ */ hw->irqnum = irq_of_parse_and_map(np, 0); + if (hw->irqnum <= 0) + goto free_host; + ret = request_irq(hw->irqnum, spi_ppc4xx_int, 0, "spi_ppc4xx_of", (void *)hw); if (ret) {
Zero and negative number is not a valid IRQ for in-kernel code and the irq_of_parse_and_map() function returns zero on error. So this check for valid IRQs should only accept values > 0. Cc: stable@vger.kernel.org Fixes: 44dab88e7cc9 ("spi: add spi_ppc4xx driver") Signed-off-by: Ma Ke <make24@iscas.ac.cn> --- Changes in v2: - added Cc stable line; - added Fixes line. --- drivers/spi/spi-ppc4xx.c | 3 +++ 1 file changed, 3 insertions(+)