diff mbox series

[v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done

Message ID 20240724125327.3495874-1-quic_vjakkam@quicinc.com (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show
Series [v2] wifi: cfg80211: fix reporting failed MLO links status with cfg80211_connect_done | expand

Commit Message

Veerendranath Jakkam July 24, 2024, 12:53 p.m. UTC
Individual MLO links connection status not copied to
EVENT_CONNECT_RESULT data while processing the connect response
information in cfg80211_connect_done(). Due to this failed links also
indicated with success status in EVENT_CONNECT_RESULT.

To fix this, copy the individual MLO links status to
EVENT_CONNECT_RESULT data.

Fixes: 53ad07e9823b ("wifi: cfg80211: support reporting failed links")
Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com>
---
v2:
 - Add "Fixes:" tag in commit text.
---
 net/wireless/sme.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Carlos Llamas July 24, 2024, 1:40 p.m. UTC | #1
On Wed, Jul 24, 2024 at 06:23:27PM +0530, Veerendranath Jakkam wrote:
> Individual MLO links connection status not copied to
> EVENT_CONNECT_RESULT data while processing the connect response
> information in cfg80211_connect_done(). Due to this failed links also
> indicated with success status in EVENT_CONNECT_RESULT.
> 
> To fix this, copy the individual MLO links status to
> EVENT_CONNECT_RESULT data.
> 
> Fixes: 53ad07e9823b ("wifi: cfg80211: support reporting failed links")
> Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com>
> ---
> v2:
>  - Add "Fixes:" tag in commit text.
> ---
>  net/wireless/sme.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
> index e419aa8c4a5a..d9d7bf8bb5c1 100644
> --- a/net/wireless/sme.c
> +++ b/net/wireless/sme.c
> @@ -1045,6 +1045,7 @@ void cfg80211_connect_done(struct net_device *dev,
>  			cfg80211_hold_bss(
>  				bss_from_pub(params->links[link].bss));
>  		ev->cr.links[link].bss = params->links[link].bss;
> +		ev->cr.links[link].status = params->links[link].status;
>  
>  		if (params->links[link].addr) {
>  			ev->cr.links[link].addr = next;
> -- 
> 2.34.1
> 
LGTM,

Reviewed-by: Carlos Llamas <cmllamas@google.com>
diff mbox series

Patch

diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index e419aa8c4a5a..d9d7bf8bb5c1 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -1045,6 +1045,7 @@  void cfg80211_connect_done(struct net_device *dev,
 			cfg80211_hold_bss(
 				bss_from_pub(params->links[link].bss));
 		ev->cr.links[link].bss = params->links[link].bss;
+		ev->cr.links[link].status = params->links[link].status;
 
 		if (params->links[link].addr) {
 			ev->cr.links[link].addr = next;