diff mbox series

[3/3] arm64: dts: imx93-11x11-evk: Add audio XCVR sound card

Message ID 1721897948-6306-4-git-send-email-shengjiu.wang@nxp.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx93-11x11-evk: Add several sound cards | expand

Commit Message

Shengjiu Wang July 25, 2024, 8:59 a.m. UTC
Add audio XCVR sound card, which supports SPDIF TX & RX only,
eARC RX, ARC RX are not supported.

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
 .../boot/dts/freescale/imx93-11x11-evk.dts    | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)

Comments

Krzysztof Kozlowski July 25, 2024, 11:33 a.m. UTC | #1
On 25/07/2024 10:59, Shengjiu Wang wrote:
> Add audio XCVR sound card, which supports SPDIF TX & RX only,
> eARC RX, ARC RX are not supported.
> 
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)


>  };
>  
>  &adc1 {
> @@ -469,6 +482,19 @@ &wdog3 {
>  	status = "okay";
>  };
>  
> +&xcvr {
> +	#sound-dai-cells = <0>;

Why this is not a property of the SoC? This applies to other patches as
well.

Best regards,
Krzysztof
Shengjiu Wang July 26, 2024, 2:59 a.m. UTC | #2
On Thu, Jul 25, 2024 at 7:33 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 25/07/2024 10:59, Shengjiu Wang wrote:
> > Add audio XCVR sound card, which supports SPDIF TX & RX only,
> > eARC RX, ARC RX are not supported.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 40 +++++++++++++++++++
> >  1 file changed, 40 insertions(+)
>
>
> >  };
> >
> >  &adc1 {
> > @@ -469,6 +482,19 @@ &wdog3 {
> >       status = "okay";
> >  };
> >
> > +&xcvr {
> > +     #sound-dai-cells = <0>;
>
> Why this is not a property of the SoC? This applies to other patches as
> well.

I think you mean it need to move to imx93.dtsi.
Ok, will do it.

best regards
Shengjiu Wang
>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
index 7ad65469625f..0bf826fa8c11 100644
--- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
@@ -118,6 +118,19 @@  cpu {
 			};
 		};
 	};
+
+	sound-xcvr {
+		compatible = "fsl,imx-audio-card";
+		model = "imx-audio-xcvr";
+
+		pri-dai-link {
+			link-name = "XCVR PCM";
+
+			cpu {
+				sound-dai = <&xcvr>;
+			};
+		};
+	};
 };
 
 &adc1 {
@@ -469,6 +482,19 @@  &wdog3 {
 	status = "okay";
 };
 
+&xcvr {
+	#sound-dai-cells = <0>;
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&pinctrl_spdif>;
+	pinctrl-1 = <&pinctrl_spdif_sleep>;
+	assigned-clocks = <&clk IMX93_CLK_SPDIF>,
+			 <&clk IMX93_CLK_AUDIO_XCVR>;
+	assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>,
+			 <&clk IMX93_CLK_SYS_PLL_PFD1_DIV2>;
+	assigned-clock-rates = <12288000>, <200000000>;
+	status = "okay";
+};
+
 &iomuxc {
 	pinctrl_eqos: eqosgrp {
 		fsl,pins = <
@@ -680,6 +706,20 @@  MX93_PAD_SD2_RESET_B__GPIO3_IO07	0x31e
 		>;
 	};
 
+	pinctrl_spdif: spdifgrp {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO22__SPDIF_IN		0x31e
+			MX93_PAD_GPIO_IO23__SPDIF_OUT		0x31e
+		>;
+	};
+
+	pinctrl_spdif_sleep: spdifgrpsleep {
+		fsl,pins = <
+			MX93_PAD_GPIO_IO22__GPIO2_IO22		0x31e
+			MX93_PAD_GPIO_IO23__GPIO2_IO23		0x31e
+		>;
+	};
+
 	pinctrl_usdhc2_gpio: usdhc2gpiogrp {
 		fsl,pins = <
 			MX93_PAD_SD2_CD_B__GPIO3_IO00		0x31e