| Message ID | 20240725121252.865836-2-wangshuaijie@awinic.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for aw9610x proximity sensor | expand |
On Thu, 25 Jul 2024 12:12:51 +0000, wangshuaijie@awinic.com wrote: > From: shuaijie wang <wangshuaijie@awinic.com> > > Add device tree bindings for aw9610x proximity sensor. > > Signed-off-by: shuaijie wang <wangshuaijie@awinic.com> > --- > .../iio/proximity/awinic,aw9610x.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/input/awinic,aw9610x.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240725121252.865836-2-wangshuaijie@awinic.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 25/07/2024 15:17, Rob Herring (Arm) wrote: > > On Thu, 25 Jul 2024 12:12:51 +0000, wangshuaijie@awinic.com wrote: >> From: shuaijie wang <wangshuaijie@awinic.com> >> >> Add device tree bindings for aw9610x proximity sensor. >> >> Signed-off-by: shuaijie wang <wangshuaijie@awinic.com> >> --- >> .../iio/proximity/awinic,aw9610x.yaml | 61 +++++++++++++++++++ >> 1 file changed, 61 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename > $id: http://devicetree.org/schemas/input/awinic,aw9610x.yaml > file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml Look, still not tested. You got comment on v3 that you must it prior to sending. The comment also explained how to perform the testing. You responded that you will implement testing but as easily we can see here, you still did not test it. Please, stop wasting our time. TEST your patches BEFORE sending. Best regards, Krzysztof
On Thu, 25 Jul 2024 15:54:10 +0200, krzk@kernel.org wrote: >On 25/07/2024 15:17, Rob Herring (Arm) wrote: >> >> On Thu, 25 Jul 2024 12:12:51 +0000, wangshuaijie@awinic.com wrote: >>> From: shuaijie wang <wangshuaijie@awinic.com> >>> >>> Add device tree bindings for aw9610x proximity sensor. >>> >>> Signed-off-by: shuaijie wang <wangshuaijie@awinic.com> >>> --- >>> .../iio/proximity/awinic,aw9610x.yaml | 61 +++++++++++++++++++ >>> 1 file changed, 61 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename >> $id: http://devicetree.org/schemas/input/awinic,aw9610x.yaml >> file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml > >Look, still not tested. > >You got comment on v3 that you must it prior to sending. The comment >also explained how to perform the testing. > >You responded that you will implement testing but as easily we can see >here, you still did not test it. > >Please, stop wasting our time. TEST your patches BEFORE sending. > >Best regards, >Krzysztof Hi Krzysztof, I'm extremely sorry for wasting your time, and I feel incredibly guilty about it. I did see the information before, but for some reason, I didn't submit the correct patch. I apologize again for the inconvenience. I will fix this issue in the next version. Kind regards, Wang Shuaijie
diff --git a/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml b/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml new file mode 100644 index 000000000000..8071fd3f1fea --- /dev/null +++ b/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/awinic,aw9610x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Awinic's AW9610X capacitive proximity sensor + +maintainers: + - Wang Shuaijie <wangshuaijie@awinic.com> + +description: | + Awinic's AW9610X proximity sensor. + The specific absorption rate (SAR) is a metric that measures + the degree of absorption of electromagnetic radiation emitted by + wireless devices, such as mobile phones and tablets, by human tissue. + In mobile phone applications, the proximity sensor is primarily + used to detect the proximity of the human body to the phone. When the + phone approaches the human body, it will actively reduce the transmit + power of the antenna to keep the SAR within a safe range. Therefore, + we also refer to the proximity sensor as a SAR sensor. + +properties: + compatible: + enum: + - awinic,aw96103 + - awinic,aw96105 + + reg: + maxItems: 1 + + interrupts: + description: + Generated by the device to announce that a close/far + proximity event has happened. + maxItems: 1 + + vcc-supply: + description: + Optional regulator for chip, 1.7V-3.6V. + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + proximity@12 { + compatible = "awinic,aw96103"; + reg = <0x12>; + interrupt-parent = <&gpio>; + interrupts = <23 IRQ_TYPE_EDGE_FALLING>; + }; + };