| Message ID | 20240726-x1e80100-pcie-disable-l0s-v1-1-8291e133a534@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: qcom: Disable ASPM L0s on x1e801800 | expand |
On Fri, Jul 26, 2024 at 09:54:13AM +0300, Abel Vesa wrote: > Confirmed by Qualcomm that the L0s should be disabled on this platform > as well. So use the sc8280xp config instead. > What are the implications of not disabling L0s? Is it not supported on this platform or the PHY sequence doesn't support L0s? Please add these info in commit message. - Mani > Fixes: 6d0c39324c5f ("PCI: qcom: Add X1E80100 PCIe support") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/pci/controller/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 0180edf3310e..04fe624b49c1 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1739,7 +1739,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, > { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, > { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, > - { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, > + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_sc8280xp }, > { } > }; > > > --- > base-commit: 864b1099d16fc7e332c3ad7823058c65f890486c > change-id: 20240725-x1e80100-pcie-disable-l0s-548a2f316eec > > Best regards, > -- > Abel Vesa <abel.vesa@linaro.org> >
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 0180edf3310e..04fe624b49c1 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1739,7 +1739,7 @@ static const struct of_device_id qcom_pcie_match[] = { { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, - { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_sc8280xp }, { } };
Confirmed by Qualcomm that the L0s should be disabled on this platform as well. So use the sc8280xp config instead. Fixes: 6d0c39324c5f ("PCI: qcom: Add X1E80100 PCIe support") Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- drivers/pci/controller/dwc/pcie-qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 864b1099d16fc7e332c3ad7823058c65f890486c change-id: 20240725-x1e80100-pcie-disable-l0s-548a2f316eec Best regards,