| Message ID | 20240729070102.3770318-3-jacobe.zang@wesion.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Add AP6275P wireless support | expand |
On 29/07/2024 09:00, Jacobe Zang wrote: > Add clocks and clock-names for brcm4329-fmac. Why? Which devices have it? If only your newest addon, then squash the patches and add appropriate allOf:if:then disallowing the clocks for others. Or maybe all of them have it? Why commit msg does not explain anything about the hardware? > > Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com> > --- Best regards, Krzysztof
>> Add clocks and clock-names for brcm4329-fmac. > > Why? Which devices have it? If only your newest addon, then squash the > patches and add appropriate allOf:if:then disallowing the clocks for > others. Or maybe all of them have it? Why commit msg does not explain > anything about the hardware? Alright... Becuase of the datasheet said hardware has one LPO clock input. So I will add allOf:if:then for this specific hardware --- Best Regards Jacobe
On 7/29/2024 10:17 AM, Jacobe Zang wrote: >>> Add clocks and clock-names for brcm4329-fmac. >> >> Why? Which devices have it? If only your newest addon, then squash the >> patches and add appropriate allOf:if:then disallowing the clocks for >> others. Or maybe all of them have it? Why commit msg does not explain >> anything about the hardware? > > Alright... Becuase of the datasheet said hardware has one LPO clock input. So > I will add allOf:if:then for this specific hardware Maybe this can help clarifying the commit message. All Broadcom wireless chips have this clock input, but often the chip end up on a wifi module that may or may not provide the clock. From chip perspective the clock input is always present, but it is optional as the chip can also use an internal clock. As such I would not choose to make this specific to this AP6275P hardware (just my 2 cents). Regards, Arend
diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml index 2c2093c77ec9a..a3607d55ef367 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml @@ -122,6 +122,14 @@ properties: NVRAM. This would normally be filled in by the bootloader from platform configuration data. + clocks: + items: + - description: External Low Power Clock input (32.768KHz) + + clock-names: + items: + - const: lpo + required: - compatible - reg