| Message ID | 20240729014940.23053-1-neilb@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | nfsd: move error code mapping to per-version code | expand |
On Mon, 2024-07-29 at 11:47 +1000, NeilBrown wrote: > These three patches replace my earlier patch > [PATCH 3/6] nfsd: Move error code mapping to per-version xdr > code. > > The mapping is now in proc code, not xdr code. > > NeilBrown > > [PATCH 1/3] nfsd: Move error code mapping to per-version proc code. > [PATCH 2/3] nfsd: be more systematic about selecting error codes for > [PATCH 3/3] nfsd: move error choice for incorrect object types to Nice cleanup! Much cleaner than having all of this error handling sprinkled all over the generic code. Reviewed-by: Jeff Layton <jlayton@kernel.org>
On Mon, Jul 29, 2024 at 11:47:21AM +1000, NeilBrown wrote: > These three patches replace my earlier patch > [PATCH 3/6] nfsd: Move error code mapping to per-version xdr code. > > The mapping is now in proc code, not xdr code. > > NeilBrown > > [PATCH 1/3] nfsd: Move error code mapping to per-version proc code. > [PATCH 2/3] nfsd: be more systematic about selecting error codes for > [PATCH 3/3] nfsd: move error choice for incorrect object types to The code duplication in fs/nfsd/{nfsproc,nfs3proc}.c is a little jarring, but the trade-off is the code is easier to understand and far less brittle in the face of major things like disabling or even deprecating an NFS version. I've made a few minor edits and optimizations and applied these three, with Christoph's nits addressed, to nfsd-next (for v6.12). Please check my work (it's been pushed git.kernel.org).
These three patches replace my earlier patch [PATCH 3/6] nfsd: Move error code mapping to per-version xdr code. The mapping is now in proc code, not xdr code. NeilBrown [PATCH 1/3] nfsd: Move error code mapping to per-version proc code. [PATCH 2/3] nfsd: be more systematic about selecting error codes for [PATCH 3/3] nfsd: move error choice for incorrect object types to