| Message ID | 20240727170604.9149-2-eugene.shalygin@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | (asus-ec-sensors): remove VRM temp X570-E GAMING | expand |
On Sat, Jul 27, 2024 at 07:04:52PM +0200, Eugene Shalygin wrote: > From: RobotRoss <true.robot.ross@gmail.com> > > There is no hardware support, it seems the sensor was added by mistake [1]. > > [1] https://github.com/zeule/asus-ec-sensors/pull/58 > Such a reference in an upstream git log has little if any value since it may be deleted at some point. On top of that "it seems the sensor was added by mistake" doesn't really add value either. "X570-E GAMING does not support the VRM temperature sensor." would have been good enough. > Signed-off-by: RobotRoss <true.robot.ross@gmail.com> Hmm, that very much looks like an alias. Guenter > Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com> > --- > drivers/hwmon/asus-ec-sensors.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c > index 6bb8d7b1d219..ee396f21fac5 100644 > --- a/drivers/hwmon/asus-ec-sensors.c > +++ b/drivers/hwmon/asus-ec-sensors.c > @@ -420,7 +420,7 @@ static const struct ec_board_info board_info_strix_b550_i_gaming = { > > static const struct ec_board_info board_info_strix_x570_e_gaming = { > .sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB | > - SENSOR_TEMP_T_SENSOR | SENSOR_TEMP_VRM | > + SENSOR_TEMP_T_SENSOR | > SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU | > SENSOR_IN_CPU_CORE, > .mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX, > -- > 2.45.2 > >
Hi Guenter, On Sun, 28 Jul 2024 at 00:09, Guenter Roeck <linux@roeck-us.net> wrote: > "X570-E GAMING does not support the VRM temperature sensor." > > would have been good enough. I can easily change the commit message, of course, > > Signed-off-by: RobotRoss <true.robot.ross@gmail.com> > > Hmm, that very much looks like an alias. but what can I do about user email? I can ask them to provide their real name, but they saw your email as well already... Cheers, Eugene
On 7/29/24 01:20, Eugene Shalygin wrote: > Hi Guenter, > > On Sun, 28 Jul 2024 at 00:09, Guenter Roeck <linux@roeck-us.net> wrote: >> "X570-E GAMING does not support the VRM temperature sensor." >> >> would have been good enough. > > I can easily change the commit message, of course, > >>> Signed-off-by: RobotRoss <true.robot.ross@gmail.com> >> >> Hmm, that very much looks like an alias. > > but what can I do about user email? I can ask them to provide their > real name, but they saw your email as well already... > Process explicitly says then you just add a line saying:: Signed-off-by: Random J Developer <random@developer.example.org> using a known identity (sorry, no anonymous contributions.) where an alias is clearly an anonymous contribution. You could author yourself and add a comment along the line of "originally from github user RobotRoss". Guenter
Hi Günter, Thank you for all the clarifications! I learned the author's name and submitted v3. Cheers, Eugene On Mon, 29 Jul 2024 at 15:49, Guenter Roeck <linux@roeck-us.net> wrote: > > On 7/29/24 01:20, Eugene Shalygin wrote: > > Hi Guenter, > > > > On Sun, 28 Jul 2024 at 00:09, Guenter Roeck <linux@roeck-us.net> wrote: > >> "X570-E GAMING does not support the VRM temperature sensor." > >> > >> would have been good enough. > > > > I can easily change the commit message, of course, > > > >>> Signed-off-by: RobotRoss <true.robot.ross@gmail.com> > >> > >> Hmm, that very much looks like an alias. > > > > but what can I do about user email? I can ask them to provide their > > real name, but they saw your email as well already... > > > > Process explicitly says > > then you just add a line saying:: > > Signed-off-by: Random J Developer <random@developer.example.org> > > using a known identity (sorry, no anonymous contributions.) > > where an alias is clearly an anonymous contribution. You could author > yourself and add a comment along the line of "originally from github user > RobotRoss". > > Guenter >
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c index 6bb8d7b1d219..ee396f21fac5 100644 --- a/drivers/hwmon/asus-ec-sensors.c +++ b/drivers/hwmon/asus-ec-sensors.c @@ -420,7 +420,7 @@ static const struct ec_board_info board_info_strix_b550_i_gaming = { static const struct ec_board_info board_info_strix_x570_e_gaming = { .sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB | - SENSOR_TEMP_T_SENSOR | SENSOR_TEMP_VRM | + SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CHIPSET | SENSOR_CURR_CPU | SENSOR_IN_CPU_CORE, .mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,