| Message ID | 63f5d56a0d8c81d70f720c9ad2ca3861c7ce85e8.1722325265.git.lorenzo@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for EN7581 to mt7530 driver | expand |
On 30/07/2024 10:46, Lorenzo Bianconi wrote: > Add documentation for the built-in switch which can be found in the > Airoha EN7581 SoC. > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > --- > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index 7e405ad96eb2..aa89bc89eb45 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -92,6 +92,10 @@ properties: > Built-in switch of the MT7988 SoC > const: mediatek,mt7988-switch > > + - description: > + Built-in switch of the Airoha EN7581 SoC > + const: airoha,en7581-switch > + > reg: > maxItems: 1 > > @@ -284,7 +288,10 @@ allOf: > - if: > properties: > compatible: > - const: mediatek,mt7988-switch > + contains: > + enum: > + - mediatek,mt7988-switch > + - airoha,en7581-switch The compatible string won't be more than one item. So this would be a better description: compatible: oneOf: - const: mediatek,mt7988-switch - const: airoha,en7581-switch Arınç
> On 30/07/2024 10:46, Lorenzo Bianconi wrote: > > Add documentation for the built-in switch which can be found in the > > Airoha EN7581 SoC. > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > > --- > > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > index 7e405ad96eb2..aa89bc89eb45 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > @@ -92,6 +92,10 @@ properties: > > Built-in switch of the MT7988 SoC > > const: mediatek,mt7988-switch > > + - description: > > + Built-in switch of the Airoha EN7581 SoC > > + const: airoha,en7581-switch > > + > > reg: > > maxItems: 1 > > @@ -284,7 +288,10 @@ allOf: > > - if: > > properties: > > compatible: > > - const: mediatek,mt7988-switch > > + contains: > > + enum: > > + - mediatek,mt7988-switch > > + - airoha,en7581-switch > > The compatible string won't be more than one item. So this would be a > better description: > > compatible: > oneOf: > - const: mediatek,mt7988-switch > - const: airoha,en7581-switch > > Arınç ack, I will fix it in v2. Regards, Lorenzo
On Tue, Jul 30, 2024 at 11:57:36AM +0300, Arınç ÜNAL wrote: > On 30/07/2024 10:46, Lorenzo Bianconi wrote: > > Add documentation for the built-in switch which can be found in the > > Airoha EN7581 SoC. > > > > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> > > --- > > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > index 7e405ad96eb2..aa89bc89eb45 100644 > > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > > @@ -92,6 +92,10 @@ properties: > > Built-in switch of the MT7988 SoC > > const: mediatek,mt7988-switch > > + - description: > > + Built-in switch of the Airoha EN7581 SoC > > + const: airoha,en7581-switch > > + > > reg: > > maxItems: 1 > > @@ -284,7 +288,10 @@ allOf: > > - if: > > properties: > > compatible: > > - const: mediatek,mt7988-switch > > + contains: > > + enum: > > + - mediatek,mt7988-switch > > + - airoha,en7581-switch > > The compatible string won't be more than one item. So this would be a > better description: > > compatible: > oneOf: > - const: mediatek,mt7988-switch > - const: airoha,en7581-switch enum, not oneOf+const
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml index 7e405ad96eb2..aa89bc89eb45 100644 --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml @@ -92,6 +92,10 @@ properties: Built-in switch of the MT7988 SoC const: mediatek,mt7988-switch + - description: + Built-in switch of the Airoha EN7581 SoC + const: airoha,en7581-switch + reg: maxItems: 1 @@ -284,7 +288,10 @@ allOf: - if: properties: compatible: - const: mediatek,mt7988-switch + contains: + enum: + - mediatek,mt7988-switch + - airoha,en7581-switch then: $ref: "#/$defs/mt7530-dsa-port" properties:
Add documentation for the built-in switch which can be found in the Airoha EN7581 SoC. Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> --- .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)