| Message ID | 20240730012506.3317978-2-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1018825a9539a67aa381ff033a49355eb03bd84d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/smc: do some cleanups in smc module | expand |
On Tue, Jul 30, 2024 at 09:25:03AM +0800, Zhengchao Shao wrote: > Because linux/err.h is unreferenced in smc_loopback.h file, so > remove it. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> Thanks, I agree that noting provided by err.h appears to be used either by smc_loopback.h or files that include it. Reviewed-by: Simon Horman <horms@kernel.org>
On 7/30/24 9:25 AM, Zhengchao Shao wrote: > Because linux/err.h is unreferenced in smc_loopback.h file, so > remove it. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > net/smc/smc_loopback.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/smc/smc_loopback.h b/net/smc/smc_loopback.h > index 6dd4292dae56..04dc6808d2e1 100644 > --- a/net/smc/smc_loopback.h > +++ b/net/smc/smc_loopback.h > @@ -15,7 +15,6 @@ > #define _SMC_LOOPBACK_H > > #include <linux/device.h> > -#include <linux/err.h> > #include <net/smc.h> > > #if IS_ENABLED(CONFIG_SMC_LO) LGTM, Thanks. Reviewed-by: D. Wythe <alibuda@linux.alibaba.com>
On 2024/7/30 09:25, Zhengchao Shao wrote: > Because linux/err.h is unreferenced in smc_loopback.h file, so > remove it. > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > net/smc/smc_loopback.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/smc/smc_loopback.h b/net/smc/smc_loopback.h > index 6dd4292dae56..04dc6808d2e1 100644 > --- a/net/smc/smc_loopback.h > +++ b/net/smc/smc_loopback.h > @@ -15,7 +15,6 @@ > #define _SMC_LOOPBACK_H > > #include <linux/device.h> > -#include <linux/err.h> > #include <net/smc.h> > > #if IS_ENABLED(CONFIG_SMC_LO) Yeah.. I used err.h in several intermediate versions of smc loopback, but forgot to remove it in the final version. Thanks!
diff --git a/net/smc/smc_loopback.h b/net/smc/smc_loopback.h index 6dd4292dae56..04dc6808d2e1 100644 --- a/net/smc/smc_loopback.h +++ b/net/smc/smc_loopback.h @@ -15,7 +15,6 @@ #define _SMC_LOOPBACK_H #include <linux/device.h> -#include <linux/err.h> #include <net/smc.h> #if IS_ENABLED(CONFIG_SMC_LO)
Because linux/err.h is unreferenced in smc_loopback.h file, so remove it. Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- net/smc/smc_loopback.h | 1 - 1 file changed, 1 deletion(-)