| Message ID | 20240729-rockchip-canfd-v1-1-fa1250fd6be3@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | can: rockchip_canfd: add support for CAN-FD IP core found on Rockchip RK3568 | expand |
On Mon, Jul 29, 2024 at 03:05:32PM +0200, Marc Kleine-Budde wrote: > Add the binding of the rockchip rk3568 CAN-FD controller to the device > tree bindings documentation. Subject line space is valuable. Don't say 'binding' twice. Or anything else for that matter. > Co-developed-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > .../bindings/net/can/rockchip,canfd.yaml | 76 ++++++++++++++++++++++ > MAINTAINERS | 7 ++ > 2 files changed, 83 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > new file mode 100644 > index 000000000000..85f7ea68d8b9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/can/rockchip,canfd.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: > + Rockchip CAN-FD controller > + > +maintainers: > + - Marc Kleine-Budde <mkl@pengutronix.de> > + > +allOf: > + - $ref: can-controller.yaml# > + > +properties: > + compatible: > + oneOf: > + - const: rockchip,rk3568-canfd > + - items: > + - enum: > + - rockchip,rk3568v2-canfd > + - rockchip,rk3568v3-canfd > + - const: rockchip,rk3568-canfd > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: baudclk Just 'baud' > + - const: apb_pclk apb or pclk. > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: can > + - const: can-apb They are always for 'can' so that's redundant. I guess it is fine on the first entry, but definitely drop on the 2nd. Or do 'core' and 'apb'. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - resets > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/rk3568-cru.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + can0: can@fe570000 { > + compatible = "rockchip,rk3568-canfd"; > + reg = <0x0 0xfe570000 0x0 0x1000>; > + interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cru CLK_CAN0>, <&cru PCLK_CAN0>; > + clock-names = "baudclk", "apb_pclk"; > + resets = <&cru SRST_CAN0>, <&cru SRST_P_CAN0>; > + reset-names = "can", "can-apb"; > + }; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index c0a3d9e93689..d225dc39bd89 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19694,6 +19694,13 @@ F: Documentation/ABI/*/sysfs-driver-hid-roccat* > F: drivers/hid/hid-roccat* > F: include/linux/hid-roccat* > > +ROCKCHIP CAN-FD DRIVER > +M: Marc Kleine-Budde <mkl@pengutronix.de> > +R: kernel@pengutronix.de > +L: linux-can@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > + > ROCKCHIP CRYPTO DRIVERS > M: Corentin Labbe <clabbe@baylibre.com> > L: linux-crypto@vger.kernel.org > > -- > 2.43.0 > >
On 30.07.2024 13:21:58, Rob Herring wrote: > On Mon, Jul 29, 2024 at 03:05:32PM +0200, Marc Kleine-Budde wrote: > > Add the binding of the rockchip rk3568 CAN-FD controller to the device > > tree bindings documentation. > > Subject line space is valuable. Don't say 'binding' twice. Or anything > else for that matter. > > > Co-developed-by: Elaine Zhang <zhangqing@rock-chips.com> > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > > --- > > .../bindings/net/can/rockchip,canfd.yaml | 76 ++++++++++++++++++++++ > > MAINTAINERS | 7 ++ > > 2 files changed, 83 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > > new file mode 100644 > > index 000000000000..85f7ea68d8b9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/can/rockchip,canfd.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: > > + Rockchip CAN-FD controller > > + > > +maintainers: > > + - Marc Kleine-Budde <mkl@pengutronix.de> > > + > > +allOf: > > + - $ref: can-controller.yaml# > > + > > +properties: > > + compatible: > > + oneOf: > > + - const: rockchip,rk3568-canfd > > + - items: > > + - enum: > > + - rockchip,rk3568v2-canfd > > + - rockchip,rk3568v3-canfd > > + - const: rockchip,rk3568-canfd > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 2 > > + > > + clock-names: > > + items: > > + - const: baudclk > > Just 'baud' ok > > > + - const: apb_pclk > > apb or pclk. pclk seems to be more common. > > > + > > + resets: > > + maxItems: 2 > > + > > + reset-names: > > + items: > > + - const: can > > + - const: can-apb > > They are always for 'can' so that's redundant. I guess it is fine on > the first entry, but definitely drop on the 2nd. Or do 'core' and 'apb'. I've picked core and apb. regards, Marc
diff --git a/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml new file mode 100644 index 000000000000..85f7ea68d8b9 --- /dev/null +++ b/Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml @@ -0,0 +1,76 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/can/rockchip,canfd.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: + Rockchip CAN-FD controller + +maintainers: + - Marc Kleine-Budde <mkl@pengutronix.de> + +allOf: + - $ref: can-controller.yaml# + +properties: + compatible: + oneOf: + - const: rockchip,rk3568-canfd + - items: + - enum: + - rockchip,rk3568v2-canfd + - rockchip,rk3568v3-canfd + - const: rockchip,rk3568-canfd + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 2 + + clock-names: + items: + - const: baudclk + - const: apb_pclk + + resets: + maxItems: 2 + + reset-names: + items: + - const: can + - const: can-apb + +required: + - compatible + - reg + - interrupts + - clocks + - resets + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/rk3568-cru.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + can0: can@fe570000 { + compatible = "rockchip,rk3568-canfd"; + reg = <0x0 0xfe570000 0x0 0x1000>; + interrupts = <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru CLK_CAN0>, <&cru PCLK_CAN0>; + clock-names = "baudclk", "apb_pclk"; + resets = <&cru SRST_CAN0>, <&cru SRST_P_CAN0>; + reset-names = "can", "can-apb"; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index c0a3d9e93689..d225dc39bd89 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19694,6 +19694,13 @@ F: Documentation/ABI/*/sysfs-driver-hid-roccat* F: drivers/hid/hid-roccat* F: include/linux/hid-roccat* +ROCKCHIP CAN-FD DRIVER +M: Marc Kleine-Budde <mkl@pengutronix.de> +R: kernel@pengutronix.de +L: linux-can@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/net/can/rockchip,canfd.yaml + ROCKCHIP CRYPTO DRIVERS M: Corentin Labbe <clabbe@baylibre.com> L: linux-crypto@vger.kernel.org