| Message ID | 68b5f910bef89508e3455c768844ebe859d6ff1d.1722520779.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v3] dt-bindings: can: renesas,rcar-canfd: Document R-Car V4M support | expand |
On Thu, Aug 01, 2024 at 04:03:17PM +0200, Geert Uytterhoeven wrote: > From: Duy Nguyen <duy.nguyen.rh@renesas.com> > > Document support for the CAN-FD Interface on the Renesas R-Car V4M > (R8A779H0) SoC, which supports up to four channels. > > The CAN-FD module on R-Car V4M is very similar to the one on R-Car V4H, > but differs in some hardware parameters, as reflected by the Parameter > Status Information part of the Global IP Version Register. However, > none of this parameterization should have any impact on the driver, as > the driver does not access any register that is impacted by the > parameterization (except for the number of channels). > > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com> > [geert: Clarify R-Car V4M differences] > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <horms@kernel.org>
On Thu, 01 Aug 2024 16:03:17 +0200, Geert Uytterhoeven wrote: > From: Duy Nguyen <duy.nguyen.rh@renesas.com> > > Document support for the CAN-FD Interface on the Renesas R-Car V4M > (R8A779H0) SoC, which supports up to four channels. > > The CAN-FD module on R-Car V4M is very similar to the one on R-Car V4H, > but differs in some hardware parameters, as reflected by the Parameter > Status Information part of the Global IP Version Register. However, > none of this parameterization should have any impact on the driver, as > the driver does not access any register that is impacted by the > parameterization (except for the number of channels). > > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com> > [geert: Clarify R-Car V4M differences] > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v3: > - Add more clarification, > > v2: > - Drop RFC state now it works. > > Changes compared to the BSP: > - Restrict number of channels to four. > --- > .../bindings/net/can/renesas,rcar-canfd.yaml | 22 ++++++++++++++----- > 1 file changed, 16 insertions(+), 6 deletions(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
On 01.08.2024 16:03:17, Geert Uytterhoeven wrote: > From: Duy Nguyen <duy.nguyen.rh@renesas.com> > > Document support for the CAN-FD Interface on the Renesas R-Car V4M > (R8A779H0) SoC, which supports up to four channels. > > The CAN-FD module on R-Car V4M is very similar to the one on R-Car V4H, > but differs in some hardware parameters, as reflected by the Parameter > Status Information part of the Global IP Version Register. However, > none of this parameterization should have any impact on the driver, as > the driver does not access any register that is impacted by the > parameterization (except for the number of channels). > > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com> > [geert: Clarify R-Car V4M differences] > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Added to linux-can-next. Thanks, Marc
Hi Marc, On Tue, Aug 6, 2024 at 9:15 PM Marc Kleine-Budde <mkl@pengutronix.de> wrote: > On 01.08.2024 16:03:17, Geert Uytterhoeven wrote: > > From: Duy Nguyen <duy.nguyen.rh@renesas.com> > > > > Document support for the CAN-FD Interface on the Renesas R-Car V4M > > (R8A779H0) SoC, which supports up to four channels. > > > > The CAN-FD module on R-Car V4M is very similar to the one on R-Car V4H, > > but differs in some hardware parameters, as reflected by the Parameter > > Status Information part of the Global IP Version Register. However, > > none of this parameterization should have any impact on the driver, as > > the driver does not access any register that is impacted by the > > parameterization (except for the number of channels). > > > > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com> > > [geert: Clarify R-Car V4M differences] > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Added to linux-can-next. Looks like you are back from holidays, but haven't pushed linux-can-next recently? Thanks! Gr{oetje,eeting}s, Geert
On 30.08.2024 12:18:40, Geert Uytterhoeven wrote: > Hi Marc, > > On Tue, Aug 6, 2024 at 9:15 PM Marc Kleine-Budde <mkl@pengutronix.de> wrote: > > On 01.08.2024 16:03:17, Geert Uytterhoeven wrote: > > > From: Duy Nguyen <duy.nguyen.rh@renesas.com> > > > > > > Document support for the CAN-FD Interface on the Renesas R-Car V4M > > > (R8A779H0) SoC, which supports up to four channels. > > > > > > The CAN-FD module on R-Car V4M is very similar to the one on R-Car V4H, > > > but differs in some hardware parameters, as reflected by the Parameter > > > Status Information part of the Global IP Version Register. However, > > > none of this parameterization should have any impact on the driver, as > > > the driver does not access any register that is impacted by the > > > parameterization (except for the number of channels). > > > > > > Signed-off-by: Duy Nguyen <duy.nguyen.rh@renesas.com> > > > [geert: Clarify R-Car V4M differences] > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Added to linux-can-next. > > Looks like you are back from holidays, but haven't pushed linux-can-next > recently? I'll update the branch today and send a PR. regards, Marc
diff --git a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml index d3f45d29fa0a550a..7c5ac5d2e880bbb8 100644 --- a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml @@ -32,6 +32,7 @@ properties: - enum: - renesas,r8a779a0-canfd # R-Car V3U - renesas,r8a779g0-canfd # R-Car V4H + - renesas,r8a779h0-canfd # R-Car V4M - const: renesas,rcar-gen4-canfd # R-Car Gen4 - items: @@ -163,14 +164,23 @@ allOf: maxItems: 1 - if: - not: - properties: - compatible: - contains: - const: renesas,rcar-gen4-canfd + properties: + compatible: + contains: + const: renesas,r8a779h0-canfd then: patternProperties: - "^channel[2-7]$": false + "^channel[5-7]$": false + else: + if: + not: + properties: + compatible: + contains: + const: renesas,rcar-gen4-canfd + then: + patternProperties: + "^channel[2-7]$": false unevaluatedProperties: false