| Message ID | 20240729132934.311136-1-stefanb@linux.ibm.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support | expand |
On Mon Jul 29, 2024 at 4:29 PM EEST, Stefan Berger wrote: > Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced > CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the > following message appears in the kernel log due to a missing call to > tpm2_sessions_init(). > > [ 2.654549] tpm tpm0: auth session is not active > > Add the missing call to tpm2_session_init() to the ibmvtpm driver to > resolve this issue. > > Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation") > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > --- > drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index d3989b257f42..1e5b107d1f3b 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, > rc = tpm2_get_cc_attrs_tbl(chip); > if (rc) > goto init_irq_cleanup; > + > + rc = tpm2_sessions_init(chip); > + if (rc) > + goto init_irq_cleanup; > } > > return tpm_chip_register(chip); Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
On Mon Jul 29, 2024 at 4:29 PM EEST, Stefan Berger wrote: > Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced > CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the > following message appears in the kernel log due to a missing call to > tpm2_sessions_init(). > > [ 2.654549] tpm tpm0: auth session is not active > > Add the missing call to tpm2_session_init() to the ibmvtpm driver to > resolve this issue. > > Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation") > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > --- > drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index d3989b257f42..1e5b107d1f3b 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, > rc = tpm2_get_cc_attrs_tbl(chip); > if (rc) > goto init_irq_cleanup; > + > + rc = tpm2_sessions_init(chip); > + if (rc) > + goto init_irq_cleanup; > } > > return tpm_chip_register(chip); Cannot get emails working with my Linux machine given https://bugzilla.redhat.com/show_bug.cgi?id=2302132 I'll try to sort this out first and then do a pull request. BR, Jarkko
On Mon Jul 29, 2024 at 4:29 PM EEST, Stefan Berger wrote: > Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced > CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the > following message appears in the kernel log due to a missing call to > tpm2_sessions_init(). > > [ 2.654549] tpm tpm0: auth session is not active > > Add the missing call to tpm2_session_init() to the ibmvtpm driver to > resolve this issue. > > Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation") > Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> > --- > drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index d3989b257f42..1e5b107d1f3b 100644 > --- a/drivers/char/tpm/tpm_ibmvtpm.c > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, > rc = tpm2_get_cc_attrs_tbl(chip); > if (rc) > goto init_irq_cleanup; > + > + rc = tpm2_sessions_init(chip); > + if (rc) > + goto init_irq_cleanup; > } > > return tpm_chip_register(chip); Applied! BR, Jarkko
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c index d3989b257f42..1e5b107d1f3b 100644 --- a/drivers/char/tpm/tpm_ibmvtpm.c +++ b/drivers/char/tpm/tpm_ibmvtpm.c @@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev, rc = tpm2_get_cc_attrs_tbl(chip); if (rc) goto init_irq_cleanup; + + rc = tpm2_sessions_init(chip); + if (rc) + goto init_irq_cleanup; } return tpm_chip_register(chip);
Commit d2add27cf2b8 ("tpm: Add NULL primary creation") introduced CONFIG_TCG_TPM2_HMAC. When this option is enabled on ppc64 then the following message appears in the kernel log due to a missing call to tpm2_sessions_init(). [ 2.654549] tpm tpm0: auth session is not active Add the missing call to tpm2_session_init() to the ibmvtpm driver to resolve this issue. Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation") Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> --- drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++ 1 file changed, 4 insertions(+)