mbox series

[net-next,v4,0/7] tcp: completely support active reset

Message ID 20240802102112.9199-1-kerneljasonxing@gmail.com (mailing list archive)
Headers show
Series tcp: completely support active reset | expand

Message

Jason Xing Aug. 2, 2024, 10:21 a.m. UTC
From: Jason Xing <kernelxing@tencent.com>

This time the patch series finally covers all the cases in the active
reset logic. After this, we can know the related exact reason(s).

v4
Link:
1. revise the changelog to avoid future confusion in patch [5/7] (Eric)
2. revise the changelog of patch [6/7] like above.
3. add reviewed-by tags (Eric)

v3
Link: https://lore.kernel.org/all/20240731120955.23542-1-kerneljasonxing@gmail.com/
1. introduce TCP_DISCONNECT_WITH_DATA reason (Eric)
2. use a better name 'TCP_KEEPALIVE_TIMEOUT' (Eric)
3. add three reviewed-by tags (Eric)

v2
Link: https://lore.kernel.org/all/20240730133513.99986-1-kerneljasonxing@gmail.com/
1. use RFC 9293 in the comment and changelog instead of old RFC 793
2. correct the comment and changelog in patch 5


Jason Xing (7):
  tcp: rstreason: introduce SK_RST_REASON_TCP_ABORT_ON_CLOSE for active
    reset
  tcp: rstreason: introduce SK_RST_REASON_TCP_ABORT_ON_LINGER for active
    reset
  tcp: rstreason: introduce SK_RST_REASON_TCP_ABORT_ON_MEMORY for active
    reset
  tcp: rstreason: introduce SK_RST_REASON_TCP_STATE for active reset
  tcp: rstreason: introduce SK_RST_REASON_TCP_KEEPALIVE_TIMEOUT for
    active reset
  tcp: rstreason: introduce SK_RST_REASON_TCP_DISCONNECT_WITH_DATA for
    active reset
  tcp: rstreason: let it work finally in tcp_send_active_reset()

 include/net/rstreason.h | 39 +++++++++++++++++++++++++++++++++++++++
 net/ipv4/tcp.c          | 19 +++++++++++--------
 net/ipv4/tcp_output.c   |  2 +-
 net/ipv4/tcp_timer.c    |  6 +++---
 4 files changed, 54 insertions(+), 12 deletions(-)

Comments

Jakub Kicinski Aug. 2, 2024, 3:30 p.m. UTC | #1
On Fri,  2 Aug 2024 18:21:05 +0800 Jason Xing wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> This time the patch series finally covers all the cases in the active
> reset logic. After this, we can know the related exact reason(s).

What happened to waiting 24h before posting the next version? :|
Jason Xing Aug. 2, 2024, 5:43 p.m. UTC | #2
On Fri, Aug 2, 2024 at 11:30 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Fri,  2 Aug 2024 18:21:05 +0800 Jason Xing wrote:
> > From: Jason Xing <kernelxing@tencent.com>
> >
> > This time the patch series finally covers all the cases in the active
> > reset logic. After this, we can know the related exact reason(s).
>
> What happened to waiting 24h before posting the next version? :|

Ah, sorry, I didn't calculate the accurate time, but I can make sure
next time I will wait much longer and obey the rules.

> --
> pv-bot: 24h
patchwork-bot+netdevbpf@kernel.org Aug. 7, 2024, 9:30 a.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri,  2 Aug 2024 18:21:05 +0800 you wrote:
> From: Jason Xing <kernelxing@tencent.com>
> 
> This time the patch series finally covers all the cases in the active
> reset logic. After this, we can know the related exact reason(s).
> 
> v4
> Link:
> 1. revise the changelog to avoid future confusion in patch [5/7] (Eric)
> 2. revise the changelog of patch [6/7] like above.
> 3. add reviewed-by tags (Eric)
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/7] tcp: rstreason: introduce SK_RST_REASON_TCP_ABORT_ON_CLOSE for active reset
    https://git.kernel.org/netdev/net-next/c/90c36325c796
  - [net-next,v4,2/7] tcp: rstreason: introduce SK_RST_REASON_TCP_ABORT_ON_LINGER for active reset
    https://git.kernel.org/netdev/net-next/c/edc92b48abc5
  - [net-next,v4,3/7] tcp: rstreason: introduce SK_RST_REASON_TCP_ABORT_ON_MEMORY for active reset
    https://git.kernel.org/netdev/net-next/c/8407994f0c35
  - [net-next,v4,4/7] tcp: rstreason: introduce SK_RST_REASON_TCP_STATE for active reset
    https://git.kernel.org/netdev/net-next/c/edefba66d929
  - [net-next,v4,5/7] tcp: rstreason: introduce SK_RST_REASON_TCP_KEEPALIVE_TIMEOUT for active reset
    https://git.kernel.org/netdev/net-next/c/0a399892a596
  - [net-next,v4,6/7] tcp: rstreason: introduce SK_RST_REASON_TCP_DISCONNECT_WITH_DATA for active reset
    https://git.kernel.org/netdev/net-next/c/c026c6562f86
  - [net-next,v4,7/7] tcp: rstreason: let it work finally in tcp_send_active_reset()
    https://git.kernel.org/netdev/net-next/c/ba0ca286c919

You are awesome, thank you!