[2/2] gpio/omap: add *remove* callback in platform_driver

Commit Message

Kevin Hilman July 16, 2012, 5:10 p.m. UTC

Linus Walleij <[e-mail]> writes:

> On Thu, Jul 12, 2012 at 7:48 PM, Kevin Hilman <[e-mail]> wrote:
>
>> In the case of OMAP GPIO, unless it's an obvious fix, I would recommend
>> you wait at least until you see some acks/tested tags from any of
>>
>> - Santosh Shilimkar <[e-mail]>
>> - Rajendra Nayak <[e-mail]>
>> - Benoit Cousson <[e-mail]>
>>
>> or Tony, Paul or myself.
>
> Instead of trying to store this information in my and Grants brains and
> us forgetting it, what about patching MAINTAINERS to reflect the fact
> instead? That's better I think, plus I use that file a lot.
>
>> For major series, I have been collecting/queueing them for Grant after
>> ensuring they have been well reviewed and well tested (although I am
>> eagerly hoping to hand off this role to someone else.)
>
> Listing it under your GIT tree in MAINTAINERS for this driver will make
> this work better I think.
>
> One path for OMAP GPIO patches, simple. It's obviously the
> ambiguity that cause the trouble. Then you can also decide
> on each cycle whether to send these to GPIO or ARM SoC
> etc.

Yeah, I understand the process, but I've been avoiding doing that
because, well, I don't want the job.  I have been trying to get someone
else at TI to maintain this driver, but have not been successful.

So, until that happens, feel free to queue up the patch below.

Santosh, note that I've put you as co-maintainer of this driver.

Kevin


From c429e2e98ea7add98b85a47483ca7126284b22e6 Mon Sep 17 00:00:00 2001
From: Kevin Hilman <[e-mail]>
Date: Mon, 16 Jul 2012 10:05:07 -0700
Subject: [PATCH] MAINTAINERS: add entry OMAP GPIO driver

Since I've been maintaining this, making it official at the request of the
GPIO maintainers.

Cc: Grant Likely <[e-mail]>
Cc: Linus Walleij <[e-mail]>
Cc: Santosh Shilimkar <[e-mail]>
Cc: Andrew Morton <[e-mail]>
Signed-off-by: Kevin Hilman <[e-mail]>
---
 MAINTAINERS |    7 +++++++
 1 file changed, 7 insertions(+)

Comments

Linus Walleij July 16, 2012, 8:49 p.m. UTC | #1

On Mon, Jul 16, 2012 at 7:10 PM, Kevin Hilman <[e-mail]> wrote:

> Subject: [PATCH] MAINTAINERS: add entry OMAP GPIO driver
>
> Since I've been maintaining this, making it official at the request of the
> GPIO maintainers.
>
> Cc: Grant Likely <[e-mail]>
> Cc: Linus Walleij <[e-mail]>
> Cc: Santosh Shilimkar <[e-mail]>
> Cc: Andrew Morton <[e-mail]>
> Signed-off-by: Kevin Hilman <[e-mail]>

Thank! Applied, but:

> +F:     drivers/gpio/gpio.omap.c

I replaced the period with a dash:
drivers/gpio/gpio-omap.c

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Kevin Hilman July 16, 2012, 10:01 p.m. UTC | #2

Linus Walleij <[e-mail]> writes:

> On Mon, Jul 16, 2012 at 7:10 PM, Kevin Hilman <[e-mail]> wrote:
>
>> Subject: [PATCH] MAINTAINERS: add entry OMAP GPIO driver
>>
>> Since I've been maintaining this, making it official at the request of the
>> GPIO maintainers.
>>
>> Cc: Grant Likely <[e-mail]>
>> Cc: Linus Walleij <[e-mail]>
>> Cc: Santosh Shilimkar <[e-mail]>
>> Cc: Andrew Morton <[e-mail]>
>> Signed-off-by: Kevin Hilman <[e-mail]>
>
> Thank! Applied, but:
>
>> +F:     drivers/gpio/gpio.omap.c
>
> I replaced the period with a dash:
> drivers/gpio/gpio-omap.c

Ah, you caught me again trying to avoid getting mail for that driver. ;)

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Santosh Shilimkar July 17, 2012, 6:03 a.m. UTC | #3

On Mon, Jul 16, 2012 at 10:40 PM, Kevin Hilman <[e-mail]> wrote:
>
> Linus Walleij <[e-mail]> writes:
>
> > On Thu, Jul 12, 2012 at 7:48 PM, Kevin Hilman <[e-mail]> wrote:
> >
> >> In the case of OMAP GPIO, unless it's an obvious fix, I would recommend
> >> you wait at least until you see some acks/tested tags from any of
> >>
> >> - Santosh Shilimkar <[e-mail]>
> >> - Rajendra Nayak <[e-mail]>
> >> - Benoit Cousson <[e-mail]>
> >>
> >> or Tony, Paul or myself.
> >
> > Instead of trying to store this information in my and Grants brains and
> > us forgetting it, what about patching MAINTAINERS to reflect the fact
> > instead? That's better I think, plus I use that file a lot.
> >
> >> For major series, I have been collecting/queueing them for Grant after
> >> ensuring they have been well reviewed and well tested (although I am
> >> eagerly hoping to hand off this role to someone else.)
> >
> > Listing it under your GIT tree in MAINTAINERS for this driver will make
> > this work better I think.
> >
> > One path for OMAP GPIO patches, simple. It's obviously the
> > ambiguity that cause the trouble. Then you can also decide
> > on each cycle whether to send these to GPIO or ARM SoC
> > etc.
>
> Yeah, I understand the process, but I've been avoiding doing that
> because, well, I don't want the job.  I have been trying to get someone
> else at TI to maintain this driver, but have not been successful.
>
> So, until that happens, feel free to queue up the patch below.
>
> Santosh, note that I've put you as co-maintainer of this driver.
>
No problem Kevin.

Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 03df1d1..61d117a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4943,6 +4943,13 @@  S:	Maintained
 F:	drivers/usb/*/*omap*
 F:	arch/arm/*omap*/usb*
 
+OMAP GPIO DRIVER
+M:	Santosh Shilimkar <[e-mail]>
+M:	Kevin Hilman <[e-mail]>
+L:	[e-mail]
+S:	Maintained
+F:	drivers/gpio/gpio.omap.c
+
 OMFS FILESYSTEM
 M:	Bob Copeland <[e-mail]>
 L:	[e-mail]