diff mbox series

dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema

Message ID 20240807225959.3343093-1-robh@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema | expand

Commit Message

Rob Herring (Arm) Aug. 7, 2024, 10:59 p.m. UTC
The "fsl,weim-cs-timing" property is an array, but the constraints in
the if/then schema are for a matrix. That worked fine when all
properties were decoded into a matrix, but now dtschema decodes
properties into scalars and arrays based on their type.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../memory-controllers/fsl/fsl,imx-weim.yaml  | 25 ++++++++-----------
 1 file changed, 11 insertions(+), 14 deletions(-)

Comments

Peng Fan Aug. 8, 2024, 2:20 a.m. UTC | #1
> Subject: [PATCH] dt-bindings: memory-controllers: fsl,imx-weim: Fix
> "fsl,weim-cs-timing" schema
> 
> The "fsl,weim-cs-timing" property is an array, but the constraints in the
> if/then schema are for a matrix. That worked fine when all properties
> were decoded into a matrix, but now dtschema decodes properties into
> scalars and arrays based on their type.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Acked-by: Peng Fan <peng.fan@nxp.com>
Krzysztof Kozlowski Aug. 8, 2024, 3:24 p.m. UTC | #2
On Wed, 07 Aug 2024 16:59:58 -0600, Rob Herring (Arm) wrote:
> The "fsl,weim-cs-timing" property is an array, but the constraints in
> the if/then schema are for a matrix. That worked fine when all
> properties were decoded into a matrix, but now dtschema decodes
> properties into scalars and arrays based on their type.
> 
> 

Applied, thanks!

[1/1] dt-bindings: memory-controllers: fsl,imx-weim: Fix "fsl,weim-cs-timing" schema
      https://git.kernel.org/krzk/linux-mem-ctrl/c/e3e4e77140b4a240865309cc543141a593be4a21

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml
index 3f40ca5b13f6..ce4ec94a561c 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,imx-weim.yaml
@@ -134,9 +134,8 @@  allOf:
           properties:
             fsl,weim-cs-timing:
               items:
-                items:
-                  - description: CSxU
-                  - description: CSxL
+                - description: CSxU
+                - description: CSxL
   - if:
       properties:
         compatible:
@@ -151,10 +150,9 @@  allOf:
           properties:
             fsl,weim-cs-timing:
               items:
-                items:
-                  - description: CSCRxU
-                  - description: CSCRxL
-                  - description: CSCRxA
+                - description: CSCRxU
+                - description: CSCRxL
+                - description: CSCRxA
   - if:
       properties:
         compatible:
@@ -171,13 +169,12 @@  allOf:
           properties:
             fsl,weim-cs-timing:
               items:
-                items:
-                  - description: CSxGCR1
-                  - description: CSxGCR2
-                  - description: CSxRCR1
-                  - description: CSxRCR2
-                  - description: CSxWCR1
-                  - description: CSxWCR2
+                - description: CSxGCR1
+                - description: CSxGCR2
+                - description: CSxRCR1
+                - description: CSxRCR2
+                - description: CSxWCR1
+                - description: CSxWCR2
 
 additionalProperties: false