diff mbox series

[v3,1/2] dt-bindings: PCI: xilinx-xdma: Add schemas for Xilinx QDMA PCIe Root Port Bridge

Message ID 20240809060955.1982335-2-thippesw@amd.com (mailing list archive)
State Superseded
Headers show
Series Add support for Xilinx XDMA Soft IP as Root Port | expand

Commit Message

Thippeswamy Havalige Aug. 9, 2024, 6:09 a.m. UTC
Add YAML devicetree schemas for Xilinx QDMA Soft IP PCIe Root Port
Bridge.

Signed-off-by: Thippeswamy Havalige <thippesw@amd.com>
---
 .../devicetree/bindings/pci/xlnx,xdma-host.yaml    | 36 ++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)
---
changes in v3
- constrain the new entry to only the new compatible.
- Remove example.

changes in v2
- update dt node label with pcie.
---

Comments

Conor Dooley Aug. 9, 2024, 2:50 p.m. UTC | #1
On Fri, Aug 09, 2024 at 11:39:54AM +0530, Thippeswamy Havalige wrote:
> Add YAML devicetree schemas for Xilinx QDMA Soft IP PCIe Root Port
> Bridge.
> 
> Signed-off-by: Thippeswamy Havalige <thippesw@amd.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Rob Herring (Arm) Aug. 9, 2024, 6:10 p.m. UTC | #2
On Fri, Aug 09, 2024 at 11:39:54AM +0530, Thippeswamy Havalige wrote:
> Add YAML devicetree schemas for Xilinx QDMA Soft IP PCIe Root Port
> Bridge.
> 
> Signed-off-by: Thippeswamy Havalige <thippesw@amd.com>
> ---
>  .../devicetree/bindings/pci/xlnx,xdma-host.yaml    | 36 ++++++++++++++++++++--
>  1 file changed, 34 insertions(+), 2 deletions(-)
> ---
> changes in v3
> - constrain the new entry to only the new compatible.
> - Remove example.
> 
> changes in v2
> - update dt node label with pcie.
> ---
> diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> index 2f59b3a..f1efd919 100644
> --- a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> @@ -14,10 +14,21 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: xlnx,xdma-host-3.00
> +    enum:
> +      - xlnx,xdma-host-3.00
> +      - xlnx,qdma-host-3.00

Kind of odd that both IP have the exact same version number. Please 
explain in the commit message where it comes from. If you just copied it 
from the previous one, then nak.

>  
>    reg:
> -    maxItems: 1
> +    items:
> +      - description: configuration region and XDMA bridge register.
> +      - description: QDMA bridge register.
> +    minItems: 1
> +
> +  reg-names:
> +    items:
> +      - const: cfg
> +      - const: breg
> +    minItems: 1
>  
>    ranges:
>      maxItems: 2
> @@ -76,6 +87,27 @@ required:
>    - "#interrupt-cells"
>    - interrupt-controller
>  
> +if:
> +  properties:
> +    compatible:
> +      contains:
> +        enum:
> +          - xlnx,qdma-host-3.00
> +then:
> +  properties:
> +    reg:
> +      minItems: 2
> +    reg-names:
> +      minItems: 2
> +  required:
> +    - reg-names
> +else:
> +  properties:
> +    reg:
> +      maxItems: 1
> +    reg-names:
> +      maxItems: 1
> +
>  unevaluatedProperties: false
>  
>  examples:
> -- 
> 1.8.3.1
>
Havalige, Thippeswamy Aug. 11, 2024, 2:13 a.m. UTC | #3
Hi Rob Herring,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Friday, August 9, 2024 11:40 PM
> To: Havalige, Thippeswamy <thippeswamy.havalige@amd.com>
> Cc: lpieralisi@kernel.org; kw@linux.com; bhelgaas@google.com;
> krzk+dt@kernel.org; conor+dt@kernel.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linux-pci@vger.kernel.org; Havalige,
> Thippeswamy <thippeswamy.havalige@amd.com>; linux-arm-
> kernel@lists.infradead.org; Simek, Michal <michal.simek@amd.com>
> Subject: Re: [PATCH v3 1/2] dt-bindings: PCI: xilinx-xdma: Add schemas for
> Xilinx QDMA PCIe Root Port Bridge
> 
> On Fri, Aug 09, 2024 at 11:39:54AM +0530, Thippeswamy Havalige wrote:
> > Add YAML devicetree schemas for Xilinx QDMA Soft IP PCIe Root Port
> > Bridge.
> >
> > Signed-off-by: Thippeswamy Havalige <thippesw@amd.com>
> > ---
> >  .../devicetree/bindings/pci/xlnx,xdma-host.yaml    | 36
> ++++++++++++++++++++--
> >  1 file changed, 34 insertions(+), 2 deletions(-)
> > ---
> > changes in v3
> > - constrain the new entry to only the new compatible.
> > - Remove example.
> >
> > changes in v2
> > - update dt node label with pcie.
> > ---
> > diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> > index 2f59b3a..f1efd919 100644
> > --- a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> > +++ b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
> > @@ -14,10 +14,21 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    const: xlnx,xdma-host-3.00
> > +    enum:
> > +      - xlnx,xdma-host-3.00
> > +      - xlnx,qdma-host-3.00
> 
> Kind of odd that both IP have the exact same version number. Please
> explain in the commit message where it comes from. If you just copied it
> from the previous one, then nak.
When QDMA IP bought up we were using 3.0 version initially so the compatible 
String is xlnx,qdma-host-3.00 
> 
> >
> >    reg:
> > -    maxItems: 1
> > +    items:
> > +      - description: configuration region and XDMA bridge register.
> > +      - description: QDMA bridge register.
> > +    minItems: 1
> > +
> > +  reg-names:
> > +    items:
> > +      - const: cfg
> > +      - const: breg
> > +    minItems: 1
> >
> >    ranges:
> >      maxItems: 2
> > @@ -76,6 +87,27 @@ required:
> >    - "#interrupt-cells"
> >    - interrupt-controller
> >
> > +if:
> > +  properties:
> > +    compatible:
> > +      contains:
> > +        enum:
> > +          - xlnx,qdma-host-3.00
> > +then:
> > +  properties:
> > +    reg:
> > +      minItems: 2
> > +    reg-names:
> > +      minItems: 2
> > +  required:
> > +    - reg-names
> > +else:
> > +  properties:
> > +    reg:
> > +      maxItems: 1
> > +    reg-names:
> > +      maxItems: 1
> > +
> >  unevaluatedProperties: false
> >
> >  examples:
> > --
> > 1.8.3.1
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
index 2f59b3a..f1efd919 100644
--- a/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
+++ b/Documentation/devicetree/bindings/pci/xlnx,xdma-host.yaml
@@ -14,10 +14,21 @@  allOf:
 
 properties:
   compatible:
-    const: xlnx,xdma-host-3.00
+    enum:
+      - xlnx,xdma-host-3.00
+      - xlnx,qdma-host-3.00
 
   reg:
-    maxItems: 1
+    items:
+      - description: configuration region and XDMA bridge register.
+      - description: QDMA bridge register.
+    minItems: 1
+
+  reg-names:
+    items:
+      - const: cfg
+      - const: breg
+    minItems: 1
 
   ranges:
     maxItems: 2
@@ -76,6 +87,27 @@  required:
   - "#interrupt-cells"
   - interrupt-controller
 
+if:
+  properties:
+    compatible:
+      contains:
+        enum:
+          - xlnx,qdma-host-3.00
+then:
+  properties:
+    reg:
+      minItems: 2
+    reg-names:
+      minItems: 2
+  required:
+    - reg-names
+else:
+  properties:
+    reg:
+      maxItems: 1
+    reg-names:
+      maxItems: 1
+
 unevaluatedProperties: false
 
 examples: