| Message ID | 20240811222638.24464-2-thorsten.blum@toblux.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | io_uring/net: Remove unneeded if check in io_net_vec_assign() | expand |
On 8/11/24 4:26 PM, Thorsten Blum wrote: > kfree() already checks if its argument is NULL. Remove the unneeded if > check and fix the following Coccinelle/coccicheck warning reported by > ifnullfree.cocci: > > WARNING: NULL check before some freeing functions is not needed Yes it's not needed, but the NULL check is done after a function call. For the hot path, it's FASTER to check if it's NULL or not. I can put a comment on these, but honestly I wish the ifnullfree thing would just go away as it's hardly useful for anything. It's not like it's a bug to check for NULL first, or that it would find something useful.
On 12. Aug 2024, at 00:31, Jens Axboe <axboe@kernel.dk> wrote: > On 8/11/24 4:26 PM, Thorsten Blum wrote: >> kfree() already checks if its argument is NULL. Remove the unneeded if >> check and fix the following Coccinelle/coccicheck warning reported by >> ifnullfree.cocci: >> >> WARNING: NULL check before some freeing functions is not needed > > Yes it's not needed, but the NULL check is done after a function call. > For the hot path, it's FASTER to check if it's NULL or not. > > I can put a comment on these, but honestly I wish the ifnullfree > thing would just go away as it's hardly useful for anything. It's > not like it's a bug to check for NULL first, or that it would find > something useful. Ok, thanks for explaining.
diff --git a/io_uring/net.c b/io_uring/net.c index d08abcca89cc..9f35f1eb54cb 100644 --- a/io_uring/net.c +++ b/io_uring/net.c @@ -189,8 +189,7 @@ static int io_net_vec_assign(struct io_kiocb *req, struct io_async_msghdr *kmsg, if (iov) { req->flags |= REQ_F_NEED_CLEANUP; kmsg->free_iov_nr = kmsg->msg.msg_iter.nr_segs; - if (kmsg->free_iov) - kfree(kmsg->free_iov); + kfree(kmsg->free_iov); kmsg->free_iov = iov; } return 0;
kfree() already checks if its argument is NULL. Remove the unneeded if check and fix the following Coccinelle/coccicheck warning reported by ifnullfree.cocci: WARNING: NULL check before some freeing functions is not needed Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> --- io_uring/net.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)