diff mbox series

[for-next,13/13] RDMA/rtrs-clt: Remove an extra space

Message ID 20240809131538.944907-14-haris.iqbal@ionos.com (mailing list archive)
State Superseded
Headers show
Series Misc patches for RTRS | expand

Commit Message

Haris Iqbal Aug. 9, 2024, 1:15 p.m. UTC 
From: Jack Wang <jinpu.wang@ionos.com>

Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Alexei Pastuchov <alexei.pastuchov@ionos.com>
Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
---
 drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leon Romanovsky Aug. 11, 2024, 8:43 a.m. UTC | #1 
On Fri, Aug 09, 2024 at 03:15:38PM +0200, Md Haris Iqbal wrote:
> From: Jack Wang <jinpu.wang@ionos.com>
> 

No empty commit message, please provide a proper description.

Thanks


> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> Signed-off-by: Alexei Pastuchov <alexei.pastuchov@ionos.com>
> Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
> Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
> ---
>  drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index fb548d6a0aae..71387811b281 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -1208,7 +1208,7 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req)
>  		ret = rtrs_map_sg_fr(req, count);
>  		if (ret < 0) {
>  			rtrs_err_rl(s,
> -				     "Read request failed, failed to map  fast reg. data, err: %d\n",
> +				     "Read request failed, failed to map fast reg. data, err: %d\n",
>  				     ret);
>  			ib_dma_unmap_sg(dev->ib_dev, req->sglist, req->sg_cnt,
>  					req->dir);
> -- 
> 2.25.1
>
Jinpu Wang Aug. 12, 2024, 4:10 a.m. UTC | #2 
On Sun, Aug 11, 2024 at 10:43 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Fri, Aug 09, 2024 at 03:15:38PM +0200, Md Haris Iqbal wrote:
> > From: Jack Wang <jinpu.wang@ionos.com>
> >
>
> No empty commit message, please provide a proper description.
This is really simple change, the subject should explain it clear, but
ok, I will extend it also in the commit message.
>
> Thanks
Thx & Regards
>
>
> > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > Signed-off-by: Alexei Pastuchov <alexei.pastuchov@ionos.com>
> > Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
> > Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
> > ---
> >  drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > index fb548d6a0aae..71387811b281 100644
> > --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > @@ -1208,7 +1208,7 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req)
> >               ret = rtrs_map_sg_fr(req, count);
> >               if (ret < 0) {
> >                       rtrs_err_rl(s,
> > -                                  "Read request failed, failed to map  fast reg. data, err: %d\n",
> > +                                  "Read request failed, failed to map fast reg. data, err: %d\n",
> >                                    ret);
> >                       ib_dma_unmap_sg(dev->ib_dev, req->sglist, req->sg_cnt,
> >                                       req->dir);
> > --
> > 2.25.1
> >
Zhu Yanjun Aug. 12, 2024, 9:48 a.m. UTC | #3 
在 2024/8/12 12:10, Jinpu Wang 写道:
> On Sun, Aug 11, 2024 at 10:43 AM Leon Romanovsky <leon@kernel.org> wrote:
>>
>> On Fri, Aug 09, 2024 at 03:15:38PM +0200, Md Haris Iqbal wrote:
>>> From: Jack Wang <jinpu.wang@ionos.com>
>>>
>>
>> No empty commit message, please provide a proper description.
> This is really simple change, the subject should explain it clear, but
> ok, I will extend it also in the commit message.

For your reference, Adding "No functional changes" in commit log should 
be OK. ^_^

Zhu Yanjun

>>
>> Thanks
> Thx & Regards
>>
>>
>>> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
>>> Signed-off-by: Alexei Pastuchov <alexei.pastuchov@ionos.com>
>>> Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com>
>>> Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
>>> ---
>>>   drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
>>> index fb548d6a0aae..71387811b281 100644
>>> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
>>> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
>>> @@ -1208,7 +1208,7 @@ static int rtrs_clt_read_req(struct rtrs_clt_io_req *req)
>>>                ret = rtrs_map_sg_fr(req, count);
>>>                if (ret < 0) {
>>>                        rtrs_err_rl(s,
>>> -                                  "Read request failed, failed to map  fast reg. data, err: %d\n",
>>> +                                  "Read request failed, failed to map fast reg. data, err: %d\n",
>>>                                     ret);
>>>                        ib_dma_unmap_sg(dev->ib_dev, req->sglist, req->sg_cnt,
>>>                                        req->dir);
>>> --
>>> 2.25.1
>>>
diff mbox series

Patch

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index fb548d6a0aae..71387811b281 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -1208,7 +1208,7 @@  static int rtrs_clt_read_req(struct rtrs_clt_io_req *req)
 		ret = rtrs_map_sg_fr(req, count);
 		if (ret < 0) {
 			rtrs_err_rl(s,
-				     "Read request failed, failed to map  fast reg. data, err: %d\n",
+				     "Read request failed, failed to map fast reg. data, err: %d\n",
 				     ret);
 			ib_dma_unmap_sg(dev->ib_dev, req->sglist, req->sg_cnt,
 					req->dir);