mbox series

[v2,0/7] Add input voltage suppliers for PMIC MCP16502 regulators

Message ID 20240812135231.43744-1-andrei.simion@microchip.com (mailing list archive)
Headers show
Series Add input voltage suppliers for PMIC MCP16502 regulators | expand

Message

Andrei Simion Aug. 12, 2024, 1:52 p.m. UTC
In this series of patches, support for the *-supply property [1]  is added
(correlated with supply_name [2]) from the core regulator.
Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064

I modified the mcp16502.c driver and the dts that use this PMIC.
We added these improvements to provide a complete description of the board power scheme.

Snippet (as an example) from /sys/kernel/debug/regulator/regulator_summary
(for at91-sama7g5ek):
 # cat regulator_summary
 regulator                      use open bypass  opmode voltage current     min     max
---------------------------------------------------------------------------------------
 regulator-dummy                  1    0      0 unknown     0mV     0mA     0mV     0mV
 5V_MAIN                          6    6      0 unknown  5000mV     0mA  5000mV  5000mV
    VDD_IO                        5    4      0  normal  3300mV     0mA  3300mV  3300mV
       e1208000.mmc-vqmmc         1                                 0mA     0mV     0mV
       e1208000.mmc-vmmc          1                                 0mA  3300mV  3400mV
       e1204000.mmc-vmmc          1                                 0mA  3300mV  3400mV
       VDDOUT25                   3    2      0 unknown  2500mV     0mA  2500mV  2500mV
          e1000000.adc-vref       1                                 0mA     0mV     0mV
          e1000000.adc-vddana     1                                 0mA     0mV     0mV
    VDD_DDR                       1    0      0  normal  1350mV     0mA  1350mV  1350mV
    VDD_CORE                      1    0      0  normal  1150mV     0mA  1150mV  1150mV
    VDD_OTHER                     2    1      0  normal  1050mV     0mA  1050mV  1250mV
       cpu0-cpu                   1                                 0mA  1050mV  1225mV
    LDO1                          2    1      0 unknown  1800mV     0mA  1800mV  1800mV
       e1204000.mmc-vqmmc         1                                 0mA     0mV     0mV
    LDO2

-------------------------------------------------------------------------------------------

Changelog:

v1 -> v2:
 - drop (lvin|pvin[1-4])-supply from each regulators sub-node
 - add voltage input supply documentation in the yaml schema
 - add lvin-supply, pvin[1-4]-supply to PMIC node

Andrei Simion (7):
  regulator: mcp16502: Add supplier for regulators
  regulator: dt-bindings: microchip,mcp16502: Add voltage input supply
    documentation
  ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes
  ARM: dts: microchip: at91-sama7g54_curiosity: Add reg_5v to supply
    PMIC nodes
  ARM: dts: microchip: at91-sama5d2_icp: Add reg_5v to supply PMIC nodes
  ARM: dts: microchip: at91-sama5d27_wlsom1: Add reg_5v to supply PMIC
    nodes
  ARM: dts: microchip: sama5d29_curiosity: Add reg_5v to supply PMIC
    nodes

 .../regulator/microchip,mcp16502.yaml         | 20 +++++++++++++++++++
 .../dts/microchip/at91-sama5d27_wlsom1.dtsi   | 13 ++++++++++++
 .../dts/microchip/at91-sama5d29_curiosity.dts | 13 ++++++++++++
 .../boot/dts/microchip/at91-sama5d2_icp.dts   | 13 ++++++++++++
 .../dts/microchip/at91-sama7g54_curiosity.dts | 13 ++++++++++++
 .../arm/boot/dts/microchip/at91-sama7g5ek.dts | 13 ++++++++++++
 drivers/regulator/mcp16502.c                  | 17 ++++++++--------
 7 files changed, 94 insertions(+), 8 deletions(-)


base-commit: 9e6869691724b12e1f43655eeedc35fade38120c

Comments

Rob Herring (Arm) Aug. 12, 2024, 3:33 p.m. UTC | #1
On Mon, 12 Aug 2024 16:52:24 +0300, Andrei Simion wrote:
> In this series of patches, support for the *-supply property [1]  is added
> (correlated with supply_name [2]) from the core regulator.
> Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
> Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064
> 
> I modified the mcp16502.c driver and the dts that use this PMIC.
> We added these improvements to provide a complete description of the board power scheme.
> 
> Snippet (as an example) from /sys/kernel/debug/regulator/regulator_summary
> (for at91-sama7g5ek):
>  # cat regulator_summary
>  regulator                      use open bypass  opmode voltage current     min     max
> ---------------------------------------------------------------------------------------
>  regulator-dummy                  1    0      0 unknown     0mV     0mA     0mV     0mV
>  5V_MAIN                          6    6      0 unknown  5000mV     0mA  5000mV  5000mV
>     VDD_IO                        5    4      0  normal  3300mV     0mA  3300mV  3300mV
>        e1208000.mmc-vqmmc         1                                 0mA     0mV     0mV
>        e1208000.mmc-vmmc          1                                 0mA  3300mV  3400mV
>        e1204000.mmc-vmmc          1                                 0mA  3300mV  3400mV
>        VDDOUT25                   3    2      0 unknown  2500mV     0mA  2500mV  2500mV
>           e1000000.adc-vref       1                                 0mA     0mV     0mV
>           e1000000.adc-vddana     1                                 0mA     0mV     0mV
>     VDD_DDR                       1    0      0  normal  1350mV     0mA  1350mV  1350mV
>     VDD_CORE                      1    0      0  normal  1150mV     0mA  1150mV  1150mV
>     VDD_OTHER                     2    1      0  normal  1050mV     0mA  1050mV  1250mV
>        cpu0-cpu                   1                                 0mA  1050mV  1225mV
>     LDO1                          2    1      0 unknown  1800mV     0mA  1800mV  1800mV
>        e1204000.mmc-vqmmc         1                                 0mA     0mV     0mV
>     LDO2
> 
> -------------------------------------------------------------------------------------------
> 
> Changelog:
> 
> v1 -> v2:
>  - drop (lvin|pvin[1-4])-supply from each regulators sub-node
>  - add voltage input supply documentation in the yaml schema
>  - add lvin-supply, pvin[1-4]-supply to PMIC node
> 
> Andrei Simion (7):
>   regulator: mcp16502: Add supplier for regulators
>   regulator: dt-bindings: microchip,mcp16502: Add voltage input supply
>     documentation
>   ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes
>   ARM: dts: microchip: at91-sama7g54_curiosity: Add reg_5v to supply
>     PMIC nodes
>   ARM: dts: microchip: at91-sama5d2_icp: Add reg_5v to supply PMIC nodes
>   ARM: dts: microchip: at91-sama5d27_wlsom1: Add reg_5v to supply PMIC
>     nodes
>   ARM: dts: microchip: sama5d29_curiosity: Add reg_5v to supply PMIC
>     nodes
> 
>  .../regulator/microchip,mcp16502.yaml         | 20 +++++++++++++++++++
>  .../dts/microchip/at91-sama5d27_wlsom1.dtsi   | 13 ++++++++++++
>  .../dts/microchip/at91-sama5d29_curiosity.dts | 13 ++++++++++++
>  .../boot/dts/microchip/at91-sama5d2_icp.dts   | 13 ++++++++++++
>  .../dts/microchip/at91-sama7g54_curiosity.dts | 13 ++++++++++++
>  .../arm/boot/dts/microchip/at91-sama7g5ek.dts | 13 ++++++++++++
>  drivers/regulator/mcp16502.c                  | 17 ++++++++--------
>  7 files changed, 94 insertions(+), 8 deletions(-)
> 
> 
> base-commit: 9e6869691724b12e1f43655eeedc35fade38120c
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y microchip/at91-sama5d29_curiosity.dtb microchip/at91-sama5d2_icp.dtb microchip/at91-sama7g54_curiosity.dtb microchip/at91-sama7g5ek.dtb' for 20240812135231.43744-1-andrei.simion@microchip.com:

arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/chipid@e0020000: failed to match any schema with compatible: ['microchip,sama7g5-chipid']
arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/mmc@e120c000: failed to match any schema with compatible: ['microchip,sama7g5-sdhci', 'microchip,sam9x60-sdhci']
arch/arm/boot/dts/microchip/at91-sama7g5ek.dtb: /soc/mmc@e120c000: failed to match any schema with compatible: ['microchip,sama7g5-sdhci', 'microchip,sam9x60-sdhci']
Mark Brown Aug. 13, 2024, 3:43 p.m. UTC | #2
On Mon, 12 Aug 2024 16:52:24 +0300, Andrei Simion wrote:
> In this series of patches, support for the *-supply property [1]  is added
> (correlated with supply_name [2]) from the core regulator.
> Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
> Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064
> 
> I modified the mcp16502.c driver and the dts that use this PMIC.
> We added these improvements to provide a complete description of the board power scheme.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/7] regulator: mcp16502: Add supplier for regulators
      commit: 861289835002b733aa8715442ba555b1daa84baa
[2/7] regulator: dt-bindings: microchip,mcp16502: Add voltage input supply documentation
      commit: bf5ba94fa0b90c9433167bf143780af6c8805479

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Claudiu Beznea Aug. 24, 2024, 2:15 p.m. UTC | #3
On 12.08.2024 16:52, Andrei Simion wrote:
> In this series of patches, support for the *-supply property [1]  is added
> (correlated with supply_name [2]) from the core regulator.
> Link [1]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L471
> Link [2]: https://github.com/torvalds/linux/blob/master/drivers/regulator/core.c#L2064
> 

[ ... ]

> 
> Andrei Simion (7):

[ ... ]

>   ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes
>   ARM: dts: microchip: at91-sama7g54_curiosity: Add reg_5v to supply
>     PMIC nodes
>   ARM: dts: microchip: at91-sama5d2_icp: Add reg_5v to supply PMIC nodes
>   ARM: dts: microchip: at91-sama5d27_wlsom1: Add reg_5v to supply PMIC
>     nodes
>   ARM: dts: microchip: sama5d29_curiosity: Add reg_5v to supply PMIC
>     nodes

Applied to at91-dt, thanks!