| Message ID | 20240813052609.56527-3-kiseok.jo@irondevice.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add a driver for the Iron Device SMA1307 Amp | expand |
On 13/08/2024 07:26, Kiseok Jo wrote: > Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> > --- > .../bindings/sound/irondevice,sma1307.yaml | 67 +++++++++++++++++++ I do not see improvements. Best regards, Krzysztof
These changes only include other modifications(about definition). The feedback you provided was sent before, so it needs to be revised again. > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Tuesday, August 13, 2024 3:49 PM > To: Ki-Seok Jo <kiseok.jo@irondevice.com>; Liam Girdwood > <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; Jaroslav Kysela > <perex@perex.cz>; Takashi Iwai <tiwai@suse.com> > Cc: alsa-devel@alsa-project.org; linux-sound@vger.kernel.org; > devicetree@vger.kernel.org > Subject: Re: [PATCH 2/2] ASoC: sma1307: Add bindings for Iron Device > SMA1307 amplifier > > On 13/08/2024 07:26, Kiseok Jo wrote: > > Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> > > --- > > .../bindings/sound/irondevice,sma1307.yaml | 67 +++++++++++++++++++ > > I do not see improvements. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml new file mode 100644 index 000000000000..62625cf35c2a --- /dev/null +++ b/Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml @@ -0,0 +1,67 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/irondevice,sma1307.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Iron Device SMA1307 Audio Amplifier + +maintainers: + - Kiseok Jo <kiseok.jo@irondevice.com> + +description: + SMA1307 boosted digital speaker amplifier + with feedback-loop. + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + enum: + - irondevice,sma1307a-w + - irondevice,sma1307a-f + - irondevice,sma1307aq-f + description: + It is divided according to the package. + The WLCSP packages are denoted with 'w', and the QFN packages are denoted + with 'f'. If a 'q' is added, it indicated the product is AEC-Q100 + qualified for automotive applications. + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + description: + only in sma1307 + + '#sound-dai-cells': + const: 1 + + use-binary: + type: boolean + description: + whether to use binary files for device settings. + +required: + - compatible + - reg + - '#sound-dai-cells' + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + amplifier@1e { + compatible = "irondevice,sma1307a-w"; + reg = <0x1e>; + #sound-dai-cells = <1>; + interrupt-parent = <&gpio>; + interrupts = <4 0>; + }; + };
Signed-off-by: Kiseok Jo <kiseok.jo@irondevice.com> --- .../bindings/sound/irondevice,sma1307.yaml | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/irondevice,sma1307.yaml