| Message ID | 20240422143338.2026791-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/1] drm: fixed: Don't use "proxy" headers | expand |
On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Update header inclusions to follow IWYU (Include What You Use) > principle. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Assuming it builds, and nothing depends on other stuff from kernel.h via drm_fixed.h, Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > include/drm/drm_fixed.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h > index 81572d32db0c..387fb81d5b81 100644 > --- a/include/drm/drm_fixed.h > +++ b/include/drm/drm_fixed.h > @@ -25,8 +25,9 @@ > #ifndef DRM_FIXED_H > #define DRM_FIXED_H > > -#include <linux/kernel.h> > #include <linux/math64.h> > +#include <linux/types.h> > +#include <linux/wordpart.h> > > typedef union dfixed { > u32 full;
On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote: > On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Update header inclusions to follow IWYU (Include What You Use) > > principle. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Assuming it builds, and nothing depends on other stuff from kernel.h via > drm_fixed.h, For the record, I have built-tested this via `make allyesconfig` on x86_64. > Reviewed-by: Jani Nikula <jani.nikula@intel.com> Thank you!
On Thu, Apr 25, 2024 at 08:12:33PM +0300, Andy Shevchenko wrote: > On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote: > > On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > > Update header inclusions to follow IWYU (Include What You Use) > > > principle. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > Assuming it builds, and nothing depends on other stuff from kernel.h via > > drm_fixed.h, > > For the record, I have built-tested this via `make allyesconfig` on x86_64. > > > Reviewed-by: Jani Nikula <jani.nikula@intel.com> > > Thank you! Who is going to apply this, please?
On Tue, 13 Aug 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Thu, Apr 25, 2024 at 08:12:33PM +0300, Andy Shevchenko wrote: >> On Mon, Apr 22, 2024 at 09:49:04PM +0300, Jani Nikula wrote: >> > On Mon, 22 Apr 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: >> > > Update header inclusions to follow IWYU (Include What You Use) >> > > principle. >> > > >> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> > >> > Assuming it builds, and nothing depends on other stuff from kernel.h via >> > drm_fixed.h, >> >> For the record, I have built-tested this via `make allyesconfig` on x86_64. >> >> > Reviewed-by: Jani Nikula <jani.nikula@intel.com> >> >> Thank you! > > Who is going to apply this, please? Pushed to drm-misc-next, thanks for the patch. BR, Jani.
diff --git a/include/drm/drm_fixed.h b/include/drm/drm_fixed.h index 81572d32db0c..387fb81d5b81 100644 --- a/include/drm/drm_fixed.h +++ b/include/drm/drm_fixed.h @@ -25,8 +25,9 @@ #ifndef DRM_FIXED_H #define DRM_FIXED_H -#include <linux/kernel.h> #include <linux/math64.h> +#include <linux/types.h> +#include <linux/wordpart.h> typedef union dfixed { u32 full;
Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/drm/drm_fixed.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)