| Message ID | 20240814095727.1662908-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/2] dt-bindings: arm: rockchip: add support for Radxa ROCK Pi E v3.0 | expand |
Hi, On 8/14/24 18:57, FUKAUMI Naoki wrote: > Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip > RK3328 chip. > > [1] https://radxa.com/products/rockpi/pie > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > Changes in v4: > - update compatible string for OpenWrt this is for https://github.com/openwrt/openwrt/issues/16168 Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > - drop A-b tag > Changes in v3: > - collect A-b tag > Changes in v2: > - fix typo in commit message > - add missing --- in commit message > - add new section instead of new item in rockchip.yaml > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 2ad835f4068e..1d426d4e1928 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -790,6 +790,11 @@ properties: > - const: radxa,rockpi-e > - const: rockchip,rk3328 > > + - description: Radxa ROCK Pi E v3.0 > + items: > + - const: radxa,rock-pi-e-v3 > + - const: rockchip,rk3328 > + > - description: Radxa ROCK Pi N8 > items: > - const: radxa,rockpi-n8
Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki: > Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip > RK3328 chip. > > [1] https://radxa.com/products/rockpi/pie > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > Changes in v4: > - update compatible string for OpenWrt > - drop A-b tag > Changes in v3: > - collect A-b tag > Changes in v2: > - fix typo in commit message > - add missing --- in commit message > - add new section instead of new item in rockchip.yaml > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 2ad835f4068e..1d426d4e1928 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -790,6 +790,11 @@ properties: > - const: radxa,rockpi-e > - const: rockchip,rk3328 > > + - description: Radxa ROCK Pi E v3.0 > + items: > + - const: radxa,rock-pi-e-v3 > + - const: rockchip,rk3328 > + Please don't add a separate entry for the simple updated version. Instead group it with the original Rock Pi e above. For how to do it, look at the Radxa Zero 3w/3e .
Am Mittwoch, 14. August 2024, 12:25:54 CEST schrieb FUKAUMI Naoki: > Hi, > > On 8/14/24 18:57, FUKAUMI Naoki wrote: > > Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip > > RK3328 chip. > > > > [1] https://radxa.com/products/rockpi/pie > > > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > > --- > > Changes in v4: > > - update compatible string for OpenWrt > > this is for https://github.com/openwrt/openwrt/issues/16168 I this because openwrt used some out-of-tree devicetree? For people reading along, all the other rockpi devices follow a radxa,rockpi-foo naming scheme in their compatibles while _this_ new entry uses radxa,rock-pi-e-v3 Heiko
On Wed, 14 Aug 2024 18:57:26 +0900, FUKAUMI Naoki wrote: > Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip > RK3328 chip. > > [1] https://radxa.com/products/rockpi/pie > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > Changes in v4: > - update compatible string for OpenWrt > - drop A-b tag > Changes in v3: > - collect A-b tag > Changes in v2: > - fix typo in commit message > - add missing --- in commit message > - add new section instead of new item in rockchip.yaml > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y rockchip/rk3328-rock-pi-e-v3.dtb rockchip/rk3328-rock-pi-e.dtb' for 20240814095727.1662908-1-naoki@radxa.com: arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: hdmi@ff3c0000: interrupts: [[0, 35, 4], [0, 71, 4]] is too long from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml# arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: /phy@ff430000: failed to match any schema with compatible: ['rockchip,rk3328-hdmi-phy'] arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: /clock-controller@ff440000: failed to match any schema with compatible: ['rockchip,rk3328-cru', 'rockchip,cru', 'syscon'] arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e-v3.dtb: /clock-controller@ff440000: failed to match any schema with compatible: ['rockchip,rk3328-cru', 'rockchip,cru', 'syscon']
Hi, thanks for the review! On 8/14/24 20:30, Heiko Stübner wrote: > Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki: >> Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip >> RK3328 chip. >> >> [1] https://radxa.com/products/rockpi/pie >> >> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >> --- >> Changes in v4: >> - update compatible string for OpenWrt >> - drop A-b tag >> Changes in v3: >> - collect A-b tag >> Changes in v2: >> - fix typo in commit message >> - add missing --- in commit message >> - add new section instead of new item in rockchip.yaml >> --- >> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >> index 2ad835f4068e..1d426d4e1928 100644 >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >> @@ -790,6 +790,11 @@ properties: >> - const: radxa,rockpi-e >> - const: rockchip,rk3328 >> >> + - description: Radxa ROCK Pi E v3.0 >> + items: >> + - const: radxa,rock-pi-e-v3 >> + - const: rockchip,rk3328 >> + > > Please don't add a separate entry for the simple updated version. > Instead group it with the original Rock Pi e above. > > For how to do it, look at the Radxa Zero 3w/3e . https://patchwork.kernel.org/project/linux-rockchip/patch/20240711210526.40448-1-naoki@radxa.com/ is this right way? -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.
Hi, On 8/14/24 20:32, Heiko Stübner wrote: > Am Mittwoch, 14. August 2024, 12:25:54 CEST schrieb FUKAUMI Naoki: >> Hi, >> >> On 8/14/24 18:57, FUKAUMI Naoki wrote: >>> Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip >>> RK3328 chip. >>> >>> [1] https://radxa.com/products/rockpi/pie >>> >>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >>> --- >>> Changes in v4: >>> - update compatible string for OpenWrt >> >> this is for https://github.com/openwrt/openwrt/issues/16168 > > I this because openwrt used some out-of-tree devicetree? no, basically they use upstream dts. (in this case, dts is backported because they use v6.6 kernel.) generally their Makefile and script variables refer dts filename. (dts filename is referred as right name) > For people reading along, all the other rockpi devices follow a > > radxa,rockpi-foo there are roockpi4x and rockpis ;) > naming scheme in their compatibles while _this_ new entry uses > > radxa,rock-pi-e-v3 this is new target, so I thought new form can be used. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd.
Am Mittwoch, 14. August 2024, 22:04:51 CEST schrieb FUKAUMI Naoki: > Hi, > > thanks for the review! > > On 8/14/24 20:30, Heiko Stübner wrote: > > Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki: > >> Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip > >> RK3328 chip. > >> > >> [1] https://radxa.com/products/rockpi/pie > >> > >> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > >> --- > >> Changes in v4: > >> - update compatible string for OpenWrt > >> - drop A-b tag > >> Changes in v3: > >> - collect A-b tag > >> Changes in v2: > >> - fix typo in commit message > >> - add missing --- in commit message > >> - add new section instead of new item in rockchip.yaml > >> --- > >> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > >> index 2ad835f4068e..1d426d4e1928 100644 > >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > >> @@ -790,6 +790,11 @@ properties: > >> - const: radxa,rockpi-e > >> - const: rockchip,rk3328 > >> > >> + - description: Radxa ROCK Pi E v3.0 > >> + items: > >> + - const: radxa,rock-pi-e-v3 > >> + - const: rockchip,rk3328 > >> + > > > > Please don't add a separate entry for the simple updated version. > > Instead group it with the original Rock Pi e above. > > > > For how to do it, look at the Radxa Zero 3w/3e . > > https://patchwork.kernel.org/project/linux-rockchip/patch/20240711210526.40448-1-naoki@radxa.com/ > > is this right way? Nope. You need an enum. That's the reason I pointed to the Radxa Zero as an example [0] So your entry should look something like: - description: Radxa ROCK Pi E items: - enum: - radxa,rockpi-e - radxa,rockpi-e-v3 - const: rockchip,rk3328 that way the binding matches against both: compatible = "radxa,rockpi-e", "rockchip,rk3328" as well as compatible = "radxa,rockpi-e-v3", "rockchip,rk3328" Hope that helps a bit Heiko [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/rockchip.yaml#n844
hi, On 8/15/24 06:53, Heiko Stübner wrote: > Am Mittwoch, 14. August 2024, 22:04:51 CEST schrieb FUKAUMI Naoki: >> Hi, >> >> thanks for the review! >> >> On 8/14/24 20:30, Heiko Stübner wrote: >>> Am Mittwoch, 14. August 2024, 11:57:26 CEST schrieb FUKAUMI Naoki: >>>> Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip >>>> RK3328 chip. >>>> >>>> [1] https://radxa.com/products/rockpi/pie >>>> >>>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >>>> --- >>>> Changes in v4: >>>> - update compatible string for OpenWrt >>>> - drop A-b tag >>>> Changes in v3: >>>> - collect A-b tag >>>> Changes in v2: >>>> - fix typo in commit message >>>> - add missing --- in commit message >>>> - add new section instead of new item in rockchip.yaml >>>> --- >>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml >>>> index 2ad835f4068e..1d426d4e1928 100644 >>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml >>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml >>>> @@ -790,6 +790,11 @@ properties: >>>> - const: radxa,rockpi-e >>>> - const: rockchip,rk3328 >>>> >>>> + - description: Radxa ROCK Pi E v3.0 >>>> + items: >>>> + - const: radxa,rock-pi-e-v3 >>>> + - const: rockchip,rk3328 >>>> + >>> >>> Please don't add a separate entry for the simple updated version. >>> Instead group it with the original Rock Pi e above. >>> >>> For how to do it, look at the Radxa Zero 3w/3e . >> >> https://patchwork.kernel.org/project/linux-rockchip/patch/20240711210526.40448-1-naoki@radxa.com/ >> >> is this right way? > > Nope. You need an enum. That's the reason I pointed to the Radxa Zero as > an example [0] > > So your entry should look something like: > > - description: Radxa ROCK Pi E > items: > - enum: > - radxa,rockpi-e > - radxa,rockpi-e-v3 > - const: rockchip,rk3328 I see. I'll do it in v5. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > that way the binding matches against both: > compatible = "radxa,rockpi-e", "rockchip,rk3328" > as well as > compatible = "radxa,rockpi-e-v3", "rockchip,rk3328" > > > Hope that helps a bit > Heiko > > > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/rockchip.yaml#n844 > > >
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 2ad835f4068e..1d426d4e1928 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -790,6 +790,11 @@ properties: - const: radxa,rockpi-e - const: rockchip,rk3328 + - description: Radxa ROCK Pi E v3.0 + items: + - const: radxa,rock-pi-e-v3 + - const: rockchip,rk3328 + - description: Radxa ROCK Pi N8 items: - const: radxa,rockpi-n8
Radxa ROCK Pi E v3.0 is a compact networking SBC[1] using the Rockchip RK3328 chip. [1] https://radxa.com/products/rockpi/pie Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- Changes in v4: - update compatible string for OpenWrt - drop A-b tag Changes in v3: - collect A-b tag Changes in v2: - fix typo in commit message - add missing --- in commit message - add new section instead of new item in rockchip.yaml --- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)