| Message ID | 20240814173309.4166149-1-anthony.l.nguyen@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | idpf: XDP chapter II: convert Tx completion to libeth | expand |
On Wed, 14 Aug 2024 10:32:57 -0700 Tony Nguyen wrote: > Alexander Lobakin says: > > XDP for idpf is currently 5 chapters: > * convert Rx to libeth; > * convert Tx completion and stats to libeth (this); > * generic XDP and XSk code changes; > * actual XDP for idpf via libeth_xdp; > * XSk for idpf (^). > > Part II does the following: > * introduces generic libeth per-queue stats infra; > * adds generic libeth Tx completion routines; > * converts idpf to use generic libeth Tx comp routines; > * fixes Tx queue timeouts and robustifies Tx completion in general; > * fixes Tx event/descriptor flushes (writebacks); > * fully switches idpf per-queue stats to libeth. > > Most idpf patches again remove more lines than adds. > The perf difference is not visible by eye in common scenarios, but > the stats are now more complete and reliable, and also survive > ifups-ifdowns. I'm tossing this. Eric and Paolo are mostly AFK this month, I'm struggling to keep up and instead of helping review stuff you pile patches. That's not right.
On 8/15/2024 7:18 PM, Jakub Kicinski wrote: > Eric and Paolo are mostly AFK this month, I'm struggling to keep up > and instead of helping review stuff you pile patches. That's not right. Sorry, I wasn't aware. I'll throttle the patches I send for the rest of the month. Thanks, Tony
On Fri, 16 Aug 2024 13:31:52 -0700 Tony Nguyen wrote: > > Eric and Paolo are mostly AFK this month, I'm struggling to keep up > > and instead of helping review stuff you pile patches. That's not right. > > Sorry, I wasn't aware. I'll throttle the patches I send for the rest of > the month. I was hoping you'd take the opposite approach and push some folks to review :) But either way helps, thanks for the understanding.
On 8/16/2024 1:40 PM, Jakub Kicinski wrote: > On Fri, 16 Aug 2024 13:31:52 -0700 Tony Nguyen wrote: >>> Eric and Paolo are mostly AFK this month, I'm struggling to keep up >>> and instead of helping review stuff you pile patches. That's not right. >> >> Sorry, I wasn't aware. I'll throttle the patches I send for the rest of >> the month. > > I was hoping you'd take the opposite approach and push some folks > to review :) But either way helps, thanks for the understanding. I'll do that as well :) Thanks, Tony
From: Jakub Kicinski <kuba@kernel.org> Date: Thu, 15 Aug 2024 19:18:59 -0700 > On Wed, 14 Aug 2024 10:32:57 -0700 Tony Nguyen wrote: >> Alexander Lobakin says: >> >> XDP for idpf is currently 5 chapters: >> * convert Rx to libeth; >> * convert Tx completion and stats to libeth (this); >> * generic XDP and XSk code changes; >> * actual XDP for idpf via libeth_xdp; >> * XSk for idpf (^). >> >> Part II does the following: >> * introduces generic libeth per-queue stats infra; >> * adds generic libeth Tx completion routines; >> * converts idpf to use generic libeth Tx comp routines; >> * fixes Tx queue timeouts and robustifies Tx completion in general; >> * fixes Tx event/descriptor flushes (writebacks); >> * fully switches idpf per-queue stats to libeth. >> >> Most idpf patches again remove more lines than adds. >> The perf difference is not visible by eye in common scenarios, but >> the stats are now more complete and reliable, and also survive >> ifups-ifdowns. > > I'm tossing this. > > Eric and Paolo are mostly AFK this month, I'm struggling to keep up > and instead of helping review stuff you pile patches. That's not right. I'll help with the reviews as well. BTW can I send the netdev_feature_t to priv_flags conversion since there's only one kdoc to fix and the rest was reviewed or should I wait as well? Thanks, Olek
On Mon, 19 Aug 2024 13:58:40 +0200 Alexander Lobakin wrote: > BTW can I send the netdev_feature_t to priv_flags conversion since > there's only one kdoc to fix and the rest was reviewed or should I wait > as well? You can post, the rate limits apply to vendor drivers only.