| Message ID | 20240816102345.16481-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [1/2] dt-bindings: misc: qcom,fastrpc: document new domain ID | expand |
On 16/08/2024 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > index c27a8f33d8d7..2a5b18982804 100644 > --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > @@ -26,6 +26,7 @@ properties: > - mdsp > - sdsp > - cdsp > + - cdsp1 Are there more than one cdsp domains? Why adding suffixes? Driver source code does not have "cdsp1" domain, so this is confusing. Best regards, Krzysztof
On Fri, Aug 16, 2024 at 1:21 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 16/08/2024 12:23, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > index c27a8f33d8d7..2a5b18982804 100644 > > --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml > > @@ -26,6 +26,7 @@ properties: > > - mdsp > > - sdsp > > - cdsp > > + - cdsp1 > > Are there more than one cdsp domains? Why adding suffixes? Driver source > code does not have "cdsp1" domain, so this is confusing. > > Best regards, > Krzysztof > It does, Srini picked up this patch earlier today. I'm not an expert in fast RPC but it looks like the domain ID number matters here. Bart [1] https://lore.kernel.org/all/20240805-topic-sa8775p-iot-remoteproc-v4-4-86affdc72c04@linaro.org/
On 16/08/2024 14:29, Bartosz Golaszewski wrote: > On Fri, Aug 16, 2024 at 1:21 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On 16/08/2024 12:23, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> >>> Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. >>> >>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> >>> --- >>> Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> index c27a8f33d8d7..2a5b18982804 100644 >>> --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml >>> @@ -26,6 +26,7 @@ properties: >>> - mdsp >>> - sdsp >>> - cdsp >>> + - cdsp1 >> >> Are there more than one cdsp domains? Why adding suffixes? Driver source >> code does not have "cdsp1" domain, so this is confusing. >> >> Best regards, >> Krzysztof >> > > It does, Srini picked up this patch earlier today. I'm not an expert > in fast RPC but it looks like the domain ID number matters here. Ah, ok, I did not see driver change here so it was a bit confusing. Best regards, Krzysztof
On 16/08/2024 12:23, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 16 Aug 2024 12:23:44 +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > Add "cdsp1" as the new supported label for the CDSP1 fastrpc domain. > > Applied, thanks! [2/2] arm64: dts: qcom: sa8775p: fix the fastrpc label commit: b45af698d5114f9b666c7d8b58a9111d0526d7f7 Best regards,
diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml index c27a8f33d8d7..2a5b18982804 100644 --- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml +++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml @@ -26,6 +26,7 @@ properties: - mdsp - sdsp - cdsp + - cdsp1 memory-region: maxItems: 1