| Message ID | 20240816100404.879598-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Delegated to: | Matthieu Baerts |
| Headers | show |
| Series | [-next] mptcp: Remove unused declaration mptcp_sockopt_sync() | expand |
| Context | Check | Description |
|---|---|---|
| matttbe/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| matttbe/shellcheck | success | MPTCP selftests files have not been modified |
| matttbe/build | success | Build and static analysis OK |
| matttbe/KVM_Validation__normal | success | Success! ✅ |
| matttbe/KVM_Validation__debug | success | Success! ✅ |
| matttbe/KVM_Validation__btf__only_bpftest_all_ | success | Success! ✅ |
Hi Yue Haibing, On 16/08/2024 12:04, Yue Haibing wrote: > Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization") > removed the implementation but leave declaration. Good catch, it looks good to me: Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> @Netdev maintainers: it can be applied in net-next, or in -net if you prefer. Cheers, Matt
Hi Yue,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10418496805
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/ca2f2e90bcfb
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=880284
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
On Fri, Aug 16, 2024 at 06:04:04PM +0800, Yue Haibing wrote: > Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization") > removed the implementation but leave declaration. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 16 Aug 2024 18:04:04 +0800 you wrote: > Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization") > removed the implementation but leave declaration. > > Signed-off-by: Yue Haibing <yuehaibing@huawei.com> > --- > net/mptcp/protocol.h | 1 - > 1 file changed, 1 deletion(-) Here is the summary with links: - [-next] mptcp: Remove unused declaration mptcp_sockopt_sync() https://git.kernel.org/netdev/net-next/c/af3dc0ad3167 You are awesome, thank you!
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index 60c6b073d65f..08387140a646 100644 --- a/net/mptcp/protocol.h +++ b/net/mptcp/protocol.h @@ -1154,7 +1154,6 @@ static inline void mptcp_pm_close_subflow(struct mptcp_sock *msk) spin_unlock_bh(&msk->pm.lock); } -void mptcp_sockopt_sync(struct mptcp_sock *msk, struct sock *ssk); void mptcp_sockopt_sync_locked(struct mptcp_sock *msk, struct sock *ssk); static inline struct mptcp_ext *mptcp_get_ext(const struct sk_buff *skb)
Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization") removed the implementation but leave declaration. Signed-off-by: Yue Haibing <yuehaibing@huawei.com> --- net/mptcp/protocol.h | 1 - 1 file changed, 1 deletion(-)