| Message ID | 20240816-mctp-kunit-skb-fix-v1-1-3c367ac89c27@codeconstruct.com.au (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ce335db0621648472f9bb4b7191eb2e13a5793cf |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: mctp: test: Use correct skb for route input check | expand |
On Fri, Aug 16, 2024 at 06:29:17PM +0800, Jeremy Kerr wrote: > In the MCTP route input test, we're routing one skb, then (when delivery > is expected) checking the resulting routed skb. > > However, we're currently checking the original skb length, rather than > the routed skb. Check the routed skb instead; the original will have > been freed at this point. > > Fixes: 8892c0490779 ("mctp: Add route input to socket tests") > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/kernel-janitors/4ad204f0-94cf-46c5-bdab-49592addf315@kili.mountain/ > Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 16 Aug 2024 18:29:17 +0800 you wrote: > In the MCTP route input test, we're routing one skb, then (when delivery > is expected) checking the resulting routed skb. > > However, we're currently checking the original skb length, rather than > the routed skb. Check the routed skb instead; the original will have > been freed at this point. > > [...] Here is the summary with links: - [net-next] net: mctp: test: Use correct skb for route input check https://git.kernel.org/netdev/net/c/ce335db06216 You are awesome, thank you!
diff --git a/net/mctp/test/route-test.c b/net/mctp/test/route-test.c index 77e5dd422258..8551dab1d1e6 100644 --- a/net/mctp/test/route-test.c +++ b/net/mctp/test/route-test.c @@ -366,7 +366,7 @@ static void mctp_test_route_input_sk(struct kunit *test) skb2 = skb_recv_datagram(sock->sk, MSG_DONTWAIT, &rc); KUNIT_EXPECT_NOT_ERR_OR_NULL(test, skb2); - KUNIT_EXPECT_EQ(test, skb->len, 1); + KUNIT_EXPECT_EQ(test, skb2->len, 1); skb_free_datagram(sock->sk, skb2);
In the MCTP route input test, we're routing one skb, then (when delivery is expected) checking the resulting routed skb. However, we're currently checking the original skb length, rather than the routed skb. Check the routed skb instead; the original will have been freed at this point. Fixes: 8892c0490779 ("mctp: Add route input to socket tests") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/kernel-janitors/4ad204f0-94cf-46c5-bdab-49592addf315@kili.mountain/ Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au> --- net/mctp/test/route-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 34afb82a3c67f869267a26f593b6f8fc6bf35905 change-id: 20240816-mctp-kunit-skb-fix-513710d79cb5 Best regards,