| Message ID | 20240815-txgbe-kvfree-v1-1-5ecf8656f555@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1c66df862561a11a8ea9b4c97ecfe91983c3bda7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: txgbe: Remove unnecessary NULL check before free | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 15 Aug 2024 16:19:25 +0100 you wrote: > Remove unnecessary NULL check before freeing using kvfree(). > This function will ignore a NULL argument. > > Flagged by Coccinelle: > > .../txgbe_hw.c:187:2-8: WARNING: NULL check before some freeing functions is not needed. > > [...] Here is the summary with links: - net: txgbe: Remove unnecessary NULL check before free https://git.kernel.org/netdev/net-next/c/1c66df862561 You are awesome, thank you!
diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c index d6b2b3c781b6..cd1372da92a9 100644 --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c @@ -103,8 +103,7 @@ static int txgbe_calc_eeprom_checksum(struct wx *wx, u16 *checksum) if (i != wx->eeprom.sw_region_offset + TXGBE_EEPROM_CHECKSUM) *checksum += local_buffer[i]; - if (eeprom_ptrs) - kvfree(eeprom_ptrs); + kvfree(eeprom_ptrs); *checksum = TXGBE_EEPROM_SUM - *checksum;
Remove unnecessary NULL check before freeing using kvfree(). This function will ignore a NULL argument. Flagged by Coccinelle: .../txgbe_hw.c:187:2-8: WARNING: NULL check before some freeing functions is not needed. No functional change intended. Compile tested only. Signed-off-by: Simon Horman <horms@kernel.org> --- drivers/net/ethernet/wangxun/txgbe/txgbe_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)