diff mbox series

[v2,1/2] generic/732: remove unused code

Message ID 20240729084715.1736839-1-yangerkun@huawei.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] generic/732: remove unused code | expand

Commit Message

yangerkun July 29, 2024, 8:47 a.m. UTC
After commit 4fd042e0465c("generic/732: don't run it on NFS"), we will
not run this case for nfs, so remove this unused code.

Signed-off-by: Yang Erkun <yangerkun@huawei.com>
---
 tests/generic/732 | 5 -----
 1 file changed, 5 deletions(-)

Comments

Christoph Hellwig July 29, 2024, 2:16 p.m. UTC | #1
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
yangerkun Aug. 17, 2024, 6:24 a.m. UTC | #2
Hi,

Ping for this patchset.

在 2024/7/29 22:16, Christoph Hellwig 写道:
> Looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Zorro Lang Aug. 17, 2024, 7:16 p.m. UTC | #3
On Sat, Aug 17, 2024 at 02:24:26PM +0800, yangerkun wrote:
> Hi,
> 
> Ping for this patchset.

Is there anything wrong? This patchset has been merged as:

50da3fd9 generic/732: don't run it on tmpfs
52a36bfb generic/732: remove unused code

Thanks,
Zorro

> 
> 在 2024/7/29 22:16, Christoph Hellwig 写道:
> > Looks good:
> > 
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
>
yangerkun Aug. 19, 2024, 1:06 a.m. UTC | #4
在 2024/8/18 3:16, Zorro Lang 写道:
> On Sat, Aug 17, 2024 at 02:24:26PM +0800, yangerkun wrote:
>> Hi,
>>
>> Ping for this patchset.
> 
> Is there anything wrong? This patchset has been merged as:
> 
> 50da3fd9 generic/732: don't run it on tmpfs
> 52a36bfb generic/732: remove unused code

Sorry! I have not notice that this patchset has been merged to 
patches-in-queue.

> 
> Thanks,
> Zorro
> 
>>
>> 在 2024/7/29 22:16, Christoph Hellwig 写道:
>>> Looks good:
>>>
>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>
>>
Zorro Lang Aug. 19, 2024, 12:53 p.m. UTC | #5
On Mon, Aug 19, 2024 at 09:06:06AM +0800, yangerkun wrote:
> 
> 
> 在 2024/8/18 3:16, Zorro Lang 写道:
> > On Sat, Aug 17, 2024 at 02:24:26PM +0800, yangerkun wrote:
> > > Hi,
> > > 
> > > Ping for this patchset.
> > 
> > Is there anything wrong? This patchset has been merged as:
> > 
> > 50da3fd9 generic/732: don't run it on tmpfs
> > 52a36bfb generic/732: remove unused code
> 
> Sorry! I have not notice that this patchset has been merged to
> patches-in-queue.

It's not only in patches-in-queue, it's been in for-next branch
with "v2024.08.11" tag.

Thanks,
Zorro

> 
> > 
> > Thanks,
> > Zorro
> > 
> > > 
> > > 在 2024/7/29 22:16, Christoph Hellwig 写道:
> > > > Looks good:
> > > > 
> > > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > > 
> > > 
>
diff mbox series

Patch

diff --git a/tests/generic/732 b/tests/generic/732
index a571f0f5..d8475cda 100755
--- a/tests/generic/732
+++ b/tests/generic/732
@@ -34,11 +34,6 @@  testdir2=$TEST_DIR/mountpoint2-$seq
 rm -rf $testdir1 $testdir2
 mkdir -p $testdir1 $testdir2
 
-# Don't share the data and attribute caches among mount points for NFS.
-# This caching behavior is necessary to reproduce this issue as we're
-# checking the alignment of each mount point's own unique cache.
-[ "$FSTYP" = "nfs" ] && MOUNT_OPTIONS="-o nosharecache"
-
 SCRATCH_MNT=$testdir1 _scratch_mount
 SCRATCH_MNT=$testdir2 _scratch_mount
 rm -rf $testdir1/{A,B}