dt-bindings: bluetooth: bring the HW description closer to reality for wcn6855

Commit Message

Bartosz Golaszewski Aug. 13, 2024, 7:01 p.m. UTC

From: Bartosz Golaszewski <[e-mail]>

Describe the inputs from the PMU that the Bluetooth module on wcn6855
consumes and drop the ones from the host.

Signed-off-by: Bartosz Golaszewski <[e-mail]>
---
Note: This breaks the current contract but the only two users of wcn6855
upstream - sc8280xp based boards - will be updated in DTS patches sent
separately.

 .../bindings/net/bluetooth/qualcomm-bluetooth.yaml     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

[e-mail] Aug. 13, 2024, 7:33 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=879347

---Test result---

Test Summary:
CheckPatch                    PASS      0.64 seconds
GitLint                       PASS      0.32 seconds
SubjectPrefix                 FAIL      0.33 seconds
BuildKernel                   PASS      29.68 seconds
CheckAllWarning               PASS      32.42 seconds
CheckSparse                   PASS      38.18 seconds
CheckSmatch                   PASS      103.09 seconds
BuildKernel32                 PASS      29.05 seconds
TestRunnerSetup               PASS      528.63 seconds
TestRunner_l2cap-tester       PASS      19.90 seconds
TestRunner_iso-tester         FAIL      32.34 seconds
TestRunner_bnep-tester        PASS      23.78 seconds
TestRunner_mgmt-tester        PASS      110.90 seconds
TestRunner_rfcomm-tester      PASS      7.53 seconds
TestRunner_sco-tester         PASS      15.04 seconds
TestRunner_ioctl-tester       PASS      7.84 seconds
TestRunner_mesh-tester        PASS      5.98 seconds
TestRunner_smp-tester         PASS      6.92 seconds
TestRunner_userchan-tester    PASS      5.08 seconds
IncrementalBuild              PASS      27.94 seconds

Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 122, Passed: 117 (95.9%), Failed: 1, Not Run: 4

Failed Test Cases
ISO Connect2 Suspend - Success                       Failed       4.245 seconds


---
Regards,
Linux Bluetooth

Rob Herring Aug. 18, 2024, 3:07 p.m. UTC | #2

On Tue, Aug 13, 2024 at 09:01:31PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[e-mail]>
> 
> Describe the inputs from the PMU that the Bluetooth module on wcn6855
> consumes and drop the ones from the host.
> 
> Signed-off-by: Bartosz Golaszewski <[e-mail]>
> ---
> Note: This breaks the current contract but the only two users of wcn6855
> upstream - sc8280xp based boards - will be updated in DTS patches sent
> separately.

This needs to be in the commit msg.

Otherwise,

Acked-by: Rob Herring (Arm) <[e-mail]>

> 
>  .../bindings/net/bluetooth/qualcomm-bluetooth.yaml     | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> index 68c5ed111417..64a5c5004862 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> @@ -172,14 +172,14 @@ allOf:
>                - qcom,wcn6855-bt
>      then:
>        required:
> -        - enable-gpios
> -        - swctrl-gpios
> -        - vddio-supply
> -        - vddbtcxmx-supply
>          - vddrfacmn-supply
> +        - vddaon-supply
> +        - vddwlcx-supply
> +        - vddwlmx-supply
> +        - vddbtcmx-supply
>          - vddrfa0p8-supply
>          - vddrfa1p2-supply
> -        - vddrfa1p7-supply
> +        - vddrfa1p8-supply
>    - if:
>        properties:
>          compatible:
> -- 
> 2.43.0
>

Patch

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index 68c5ed111417..64a5c5004862 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -172,14 +172,14 @@  allOf:
               - qcom,wcn6855-bt
     then:
       required:
-        - enable-gpios
-        - swctrl-gpios
-        - vddio-supply
-        - vddbtcxmx-supply
         - vddrfacmn-supply
+        - vddaon-supply
+        - vddwlcx-supply
+        - vddwlmx-supply
+        - vddbtcmx-supply
         - vddrfa0p8-supply
         - vddrfa1p2-supply
-        - vddrfa1p7-supply
+        - vddrfa1p8-supply
   - if:
       properties:
         compatible: