| Message ID | 20240815074519.2684107-1-nmi@metaspace.dk (mailing list archive) |
|---|---|
| Headers | show |
| Series | rust: fix erranous use of lock class key in rust block device bindings | expand |
On Thu, 15 Aug 2024 07:49:37 +0000, Andreas Hindborg wrote: > The rust block device bindings include a wrong use of lock class key. This > causes a WARN trace when lockdep is enabled and a `GenDisk` is constructed. > > This series fixes the issue by using a static lock class key. To do this, the > series first fixes the rust build system to correctly export rust statics from > the bss segment. > > [...] Applied, thanks! [2/2] rust: block: fix wrong usage of lockdep API commit: d28b514ea3ae15274a4d70422ecc873bf6258e77 Best regards,
Hi Jens, On Thu, Aug 15, 2024 at 4:22 PM Jens Axboe <axboe@kernel.dk> wrote: > > Applied, thanks! > > [2/2] rust: block: fix wrong usage of lockdep API > commit: d28b514ea3ae15274a4d70422ecc873bf6258e77 If you picked 2/2 only, it requires the former as far as I understand. If you want to pick both: Acked-by: Miguel Ojeda <ojeda@kernel.org> Otherwise, I am happy to take them too. Thanks! Cheers, Miguel
On 8/15/24 9:31 AM, Miguel Ojeda wrote: > Hi Jens, > > On Thu, Aug 15, 2024 at 4:22?PM Jens Axboe <axboe@kernel.dk> wrote: >> >> Applied, thanks! >> >> [2/2] rust: block: fix wrong usage of lockdep API >> commit: d28b514ea3ae15274a4d70422ecc873bf6258e77 > > If you picked 2/2 only, it requires the former as far as I understand. Sorry I missed that, mostly because they were split into two separate postings. Hence it only pulled one. > If you want to pick both: > > Acked-by: Miguel Ojeda <ojeda@kernel.org> > > Otherwise, I am happy to take them too. Go ahead and take them, I'll just kill the one I have. Thanks!
On Thu, Aug 15, 2024 at 6:00 PM Jens Axboe <axboe@kernel.dk> wrote: > > Go ahead and take them, I'll just kill the one I have. Thanks! Thanks, will do! Cheers, Miguel
On Thu, Aug 15, 2024 at 9:49 AM Andreas Hindborg <nmi@metaspace.dk> wrote: > > From: Andreas Hindborg <a.hindborg@samsung.com> > > The rust block device bindings include a wrong use of lock class key. This > causes a WARN trace when lockdep is enabled and a `GenDisk` is constructed. > > This series fixes the issue by using a static lock class key. To do this, the > series first fixes the rust build system to correctly export rust statics from > the bss segment. Applied to `rust-fixes` -- thanks everyone! (I am sending the notice twice for this series, since somehow the email threads got split into two in Lore, which also broke `b4`) [ Applied `rustfmt` and reworded slightly. - Miguel ] Cheers, Miguel
On Wed, Aug 21, 2024 at 12:50 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > [ Applied `rustfmt` and reworded slightly. - Miguel ] Dirk noticed the Zulip link was broken due to a rename of the topic. Normally I try to remember to convert them into message links (which are permalinks) and to shorten them when they are too long too -- done now. For context, Zulip is gaining the ability to get topic permalinks (see https://github.com/zulip/zulip/issues/21505 -- we gave them feedback a year ago that it would be useful for kernel commits), though I think it is not exposed through the UI yet. Thanks Dirk! Cheers, Miguel
On Wed, Aug 21, 2024 at 1:36 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > Dirk noticed the Zulip link was broken due to a rename of the topic. > Normally I try to remember to convert them into message links (which > are permalinks) and to shorten them when they are too long too -- done > now. > > For context, Zulip is gaining the ability to get topic permalinks (see > https://github.com/zulip/zulip/issues/21505 -- we gave them feedback a > year ago that it would be useful for kernel commits), though I think > it is not exposed through the UI yet. It could be a good idea to warn about non-permalinks to Zulip in `checkpatch.pl` -- Cc'ing Andy and Joe and created an issue: https://github.com/Rust-for-Linux/linux/issues/1104 Cheers, Miguel
From: Andreas Hindborg <a.hindborg@samsung.com> The rust block device bindings include a wrong use of lock class key. This causes a WARN trace when lockdep is enabled and a `GenDisk` is constructed. This series fixes the issue by using a static lock class key. To do this, the series first fixes the rust build system to correctly export rust statics from the bss segment. Andreas Hindborg (2): rust: fix export of bss symbols rust: block: fix wrong usage of lockdep API rust/Makefile | 2 +- rust/kernel/block/mq/gen_disk.rs | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba