| Message ID | d7d043b2-95d5-4e1d-b340-5d7330053ac6@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c9f4c1ec69728310a31080c266b8529381c1a7fa |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: mwifiex: Fix uninitialized variable in mwifiex_cfg80211_authenticate() | expand |
On Thu, Aug 15, 2024 at 02:29:27PM +0300, Dan Carpenter wrote: > Smatch complains that: > > drivers/net/wireless/marvell/mwifiex/cfg80211.c:4408 mwifiex_cfg80211_authenticate() > error: uninitialized symbol 'varptr'. > > It's a check for NULL, but "varptr" is either non-NULL or uninitialized. > Initialize it to NULL. > > Fixes: 36995892c271 ("wifi: mwifiex: add host mlme for client mode") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Brian Norris <briannorris@chromium.org>
Dan Carpenter <dan.carpenter@linaro.org> wrote: > Smatch complains that: > > drivers/net/wireless/marvell/mwifiex/cfg80211.c:4408 mwifiex_cfg80211_authenticate() > error: uninitialized symbol 'varptr'. > > It's a check for NULL, but "varptr" is either non-NULL or uninitialized. > Initialize it to NULL. > > Fixes: 36995892c271 ("wifi: mwifiex: add host mlme for client mode") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > Acked-by: Brian Norris <briannorris@chromium.org> Patch applied to wireless-next.git, thanks. c9f4c1ec6972 wifi: mwifiex: Fix uninitialized variable in mwifiex_cfg80211_authenticate()
diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c index 722ead51e912..7505de304052 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -4284,7 +4284,7 @@ mwifiex_cfg80211_authenticate(struct wiphy *wiphy, struct mwifiex_txinfo *tx_info; u32 tx_control = 0, pkt_type = PKT_TYPE_MGMT; u8 trans = 1, status_code = 0; - u8 *varptr; + u8 *varptr = NULL; if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_UAP) { mwifiex_dbg(priv->adapter, ERROR, "Interface role is AP\n");
Smatch complains that: drivers/net/wireless/marvell/mwifiex/cfg80211.c:4408 mwifiex_cfg80211_authenticate() error: uninitialized symbol 'varptr'. It's a check for NULL, but "varptr" is either non-NULL or uninitialized. Initialize it to NULL. Fixes: 36995892c271 ("wifi: mwifiex: add host mlme for client mode") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)