[0/3] Various prime/dumb buffer fixes

Message

Zack Rusin Aug. 16, 2024, 6:32 p.m. UTC

This is the same series I've sent out earlier but with one extra patch,
that fixes the dumb buffer coherency on low mem systems.

The second patch has also been updated to not use math functions.

Zack Rusin (3):
  drm/vmwgfx: Prevent unmapping active read buffers
  drm/vmwgfx: Fix prime with external buffers
  drm/vmwgfx: Disable coherent dumb buffers without 3d

 drivers/gpu/drm/vmwgfx/vmwgfx_blit.c    | 114 +++++++++++++++++++++++-
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c      |  13 ++-
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.h      |   3 +
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h     |   4 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c    |  12 +--
 drivers/gpu/drm/vmwgfx/vmwgfx_surface.c |   6 +-
 6 files changed, 136 insertions(+), 16 deletions(-)

Comments

Maaz Mombasawala Aug. 16, 2024, 10:01 p.m. UTC | #1

On 8/16/24 11:32, Zack Rusin wrote:
> This is the same series I've sent out earlier but with one extra patch,
> that fixes the dumb buffer coherency on low mem systems.
> 
> The second patch has also been updated to not use math functions.
> 
> Zack Rusin (3):
>   drm/vmwgfx: Prevent unmapping active read buffers
>   drm/vmwgfx: Fix prime with external buffers
>   drm/vmwgfx: Disable coherent dumb buffers without 3d
> 
>  drivers/gpu/drm/vmwgfx/vmwgfx_blit.c    | 114 +++++++++++++++++++++++-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.c      |  13 ++-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.h      |   3 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h     |   4 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c    |  12 +--
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c |   6 +-
>  6 files changed, 136 insertions(+), 16 deletions(-)
> 

LGTM for the series.

Reviewed-by: Maaz Mombasawala <[e-mail]>

Martin Krastev Aug. 19, 2024, 2:40 p.m. UTC | #2

Still LGTM.

Reviewed-by: Martin Krastev <[e-mail]>

Regards,
Martin

On Fri, Aug 16, 2024 at 9:33 PM Zack Rusin <[e-mail]> wrote:
>
> This is the same series I've sent out earlier but with one extra patch,
> that fixes the dumb buffer coherency on low mem systems.
>
> The second patch has also been updated to not use math functions.
>
> Zack Rusin (3):
>   drm/vmwgfx: Prevent unmapping active read buffers
>   drm/vmwgfx: Fix prime with external buffers
>   drm/vmwgfx: Disable coherent dumb buffers without 3d
>
>  drivers/gpu/drm/vmwgfx/vmwgfx_blit.c    | 114 +++++++++++++++++++++++-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.c      |  13 ++-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.h      |   3 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h     |   4 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c    |  12 +--
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c |   6 +-
>  6 files changed, 136 insertions(+), 16 deletions(-)
>
> --
> 2.43.0
>

Benjamin Coddington Aug. 22, 2024, 2:32 p.m. UTC | #3

On 16 Aug 2024, at 14:32, Zack Rusin wrote:

> This is the same series I've sent out earlier but with one extra patch,
> that fixes the dumb buffer coherency on low mem systems.
>
> The second patch has also been updated to not use math functions.
>
> Zack Rusin (3):
>   drm/vmwgfx: Prevent unmapping active read buffers
>   drm/vmwgfx: Fix prime with external buffers
>   drm/vmwgfx: Disable coherent dumb buffers without 3d
>
>  drivers/gpu/drm/vmwgfx/vmwgfx_blit.c    | 114 +++++++++++++++++++++++-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.c      |  13 ++-
>  drivers/gpu/drm/vmwgfx/vmwgfx_bo.h      |   3 +
>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.h     |   4 +-
>  drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c    |  12 +--
>  drivers/gpu/drm/vmwgfx/vmwgfx_surface.c |   6 +-
>  6 files changed, 136 insertions(+), 16 deletions(-)
>
> -- 
> 2.43.0

I applied these three to v6.11-rc4 to fix the regression:
https://lore.kernel.org/all/[e-mail]/

Thanks for the fix! Seems to make my setup work again, so FWIW you can use my:
Tested-by: Benjamin Coddington <[e-mail]>

Ben