| Message ID | 20240802021651.3854295-1-xiaolei.wang@windriver.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: fsl: qbman: Remove redundant warnings | expand |
Hi, Le 02/08/2024 à 04:16, Xiaolei Wang a écrit : > [Vous ne recevez pas souvent de courriers de xiaolei.wang@windriver.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > RESERVEDMEM_OF_DECLARE usage has been removed. For > non-popwerpc platforms, such as ls1043, this warning > is redundant. ls1043 itself uses shared-dma-mem. Can you please explain in more details ? I don't understand what it is redundant with. Thanks Christophe > > Fixes: 3e62273ac63a ("soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage") > Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> > --- > drivers/soc/fsl/qbman/qman_ccsr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c b/drivers/soc/fsl/qbman/qman_ccsr.c > index 392e54f14dbe..aa5348f4902f 100644 > --- a/drivers/soc/fsl/qbman/qman_ccsr.c > +++ b/drivers/soc/fsl/qbman/qman_ccsr.c > @@ -791,8 +791,6 @@ static int fsl_qman_probe(struct platform_device *pdev) > * FQD memory MUST be zero'd by software > */ > zero_priv_mem(fqd_a, fqd_sz); > -#else > - WARN(1, "Unexpected architecture using non shared-dma-mem reservations"); > #endif > dev_dbg(dev, "Allocated FQD 0x%llx 0x%zx\n", fqd_a, fqd_sz); > > -- > 2.25.1 >
On 8/23/24 00:55, Christophe Leroy wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender > and know the content is safe. > > Hi, > > Le 02/08/2024 à 04:16, Xiaolei Wang a écrit : >> [Vous ne recevez pas souvent de courriers de >> xiaolei.wang@windriver.com. Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> RESERVEDMEM_OF_DECLARE usage has been removed. For >> non-popwerpc platforms, such as ls1043, this warning >> is redundant. ls1043 itself uses shared-dma-mem. > > Can you please explain in more details ? I don't understand what it is > redundant with. commit 07f86917a450 used shared-dma-pool for QMan private memory allocations and added this warning, but this is only for non-PPC platforms and using non shared-dma-mem reservations. However, for non-PPC platforms, commit 3e62273ac63a will output a warning anyway. At the same time, ls1043 already uses shared-dma-mem, so is this warning still necessary? thanks xiaolei > > Thanks > Christophe > >> >> Fixes: 3e62273ac63a ("soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE >> usage") >> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> >> --- >> drivers/soc/fsl/qbman/qman_ccsr.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c >> b/drivers/soc/fsl/qbman/qman_ccsr.c >> index 392e54f14dbe..aa5348f4902f 100644 >> --- a/drivers/soc/fsl/qbman/qman_ccsr.c >> +++ b/drivers/soc/fsl/qbman/qman_ccsr.c >> @@ -791,8 +791,6 @@ static int fsl_qman_probe(struct platform_device >> *pdev) >> * FQD memory MUST be zero'd by software >> */ >> zero_priv_mem(fqd_a, fqd_sz); >> -#else >> - WARN(1, "Unexpected architecture using non shared-dma-mem >> reservations"); >> #endif >> dev_dbg(dev, "Allocated FQD 0x%llx 0x%zx\n", fqd_a, fqd_sz); >> >> -- >> 2.25.1 >>
Le 02/08/2024 à 04:16, Xiaolei Wang a écrit : > [Vous ne recevez pas souvent de courriers de xiaolei.wang@windriver.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > RESERVEDMEM_OF_DECLARE usage has been removed. For > non-popwerpc platforms, such as ls1043, this warning > is redundant. ls1043 itself uses shared-dma-mem. > > Fixes: 3e62273ac63a ("soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage") > Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> > --- > drivers/soc/fsl/qbman/qman_ccsr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c b/drivers/soc/fsl/qbman/qman_ccsr.c > index 392e54f14dbe..aa5348f4902f 100644 > --- a/drivers/soc/fsl/qbman/qman_ccsr.c > +++ b/drivers/soc/fsl/qbman/qman_ccsr.c > @@ -791,8 +791,6 @@ static int fsl_qman_probe(struct platform_device *pdev) > * FQD memory MUST be zero'd by software > */ > zero_priv_mem(fqd_a, fqd_sz); > -#else > - WARN(1, "Unexpected architecture using non shared-dma-mem reservations"); > #endif > dev_dbg(dev, "Allocated FQD 0x%llx 0x%zx\n", fqd_a, fqd_sz); > > -- > 2.25.1 > Applied for 6.12 Thanks Christophe
diff --git a/drivers/soc/fsl/qbman/qman_ccsr.c b/drivers/soc/fsl/qbman/qman_ccsr.c index 392e54f14dbe..aa5348f4902f 100644 --- a/drivers/soc/fsl/qbman/qman_ccsr.c +++ b/drivers/soc/fsl/qbman/qman_ccsr.c @@ -791,8 +791,6 @@ static int fsl_qman_probe(struct platform_device *pdev) * FQD memory MUST be zero'd by software */ zero_priv_mem(fqd_a, fqd_sz); -#else - WARN(1, "Unexpected architecture using non shared-dma-mem reservations"); #endif dev_dbg(dev, "Allocated FQD 0x%llx 0x%zx\n", fqd_a, fqd_sz);
RESERVEDMEM_OF_DECLARE usage has been removed. For non-popwerpc platforms, such as ls1043, this warning is redundant. ls1043 itself uses shared-dma-mem. Fixes: 3e62273ac63a ("soc: fsl: qbman: Remove RESERVEDMEM_OF_DECLARE usage") Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com> --- drivers/soc/fsl/qbman/qman_ccsr.c | 2 -- 1 file changed, 2 deletions(-)