| Message ID | 20240823031129.49010-1-kunwu.chan@linux.dev (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | bus: mhi: host: make mhi_bus_type const | expand |
On Fri, Aug 23, 2024 at 11:11:28AM +0800, Kunwu Chan wrote: > From: Kunwu Chan <chentao@kylinos.cn> > > Now that the driver core can properly handle constant struct bus_type, > move the mhi_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/bus/mhi/host/init.c | 2 +- > drivers/bus/mhi/host/internal.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c > index ce7d2e62c2f1..a9b1f8beee7b 100644 > --- a/drivers/bus/mhi/host/init.c > +++ b/drivers/bus/mhi/host/init.c > @@ -1464,7 +1464,7 @@ static int mhi_match(struct device *dev, const struct device_driver *drv) > return 0; > }; > > -struct bus_type mhi_bus_type = { > +const struct bus_type mhi_bus_type = { > .name = "mhi", > .dev_name = "mhi", > .match = mhi_match, > diff --git a/drivers/bus/mhi/host/internal.h b/drivers/bus/mhi/host/internal.h > index aaad40a07f69..d057e877932e 100644 > --- a/drivers/bus/mhi/host/internal.h > +++ b/drivers/bus/mhi/host/internal.h > @@ -9,7 +9,7 @@ > > #include "../common.h" > > -extern struct bus_type mhi_bus_type; > +extern const struct bus_type mhi_bus_type; > > /* Host request register */ > #define MHI_SOC_RESET_REQ_OFFSET 0xb0 > -- > 2.41.0 >
On Fri, Aug 23, 2024 at 11:11:28AM +0800, Kunwu Chan wrote: > From: Kunwu Chan <chentao@kylinos.cn> > > Now that the driver core can properly handle constant struct bus_type, > move the mhi_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> Applied to mhi-next! - Mani > --- > drivers/bus/mhi/host/init.c | 2 +- > drivers/bus/mhi/host/internal.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c > index ce7d2e62c2f1..a9b1f8beee7b 100644 > --- a/drivers/bus/mhi/host/init.c > +++ b/drivers/bus/mhi/host/init.c > @@ -1464,7 +1464,7 @@ static int mhi_match(struct device *dev, const struct device_driver *drv) > return 0; > }; > > -struct bus_type mhi_bus_type = { > +const struct bus_type mhi_bus_type = { > .name = "mhi", > .dev_name = "mhi", > .match = mhi_match, > diff --git a/drivers/bus/mhi/host/internal.h b/drivers/bus/mhi/host/internal.h > index aaad40a07f69..d057e877932e 100644 > --- a/drivers/bus/mhi/host/internal.h > +++ b/drivers/bus/mhi/host/internal.h > @@ -9,7 +9,7 @@ > > #include "../common.h" > > -extern struct bus_type mhi_bus_type; > +extern const struct bus_type mhi_bus_type; > > /* Host request register */ > #define MHI_SOC_RESET_REQ_OFFSET 0xb0 > -- > 2.41.0 >
diff --git a/drivers/bus/mhi/host/init.c b/drivers/bus/mhi/host/init.c index ce7d2e62c2f1..a9b1f8beee7b 100644 --- a/drivers/bus/mhi/host/init.c +++ b/drivers/bus/mhi/host/init.c @@ -1464,7 +1464,7 @@ static int mhi_match(struct device *dev, const struct device_driver *drv) return 0; }; -struct bus_type mhi_bus_type = { +const struct bus_type mhi_bus_type = { .name = "mhi", .dev_name = "mhi", .match = mhi_match, diff --git a/drivers/bus/mhi/host/internal.h b/drivers/bus/mhi/host/internal.h index aaad40a07f69..d057e877932e 100644 --- a/drivers/bus/mhi/host/internal.h +++ b/drivers/bus/mhi/host/internal.h @@ -9,7 +9,7 @@ #include "../common.h" -extern struct bus_type mhi_bus_type; +extern const struct bus_type mhi_bus_type; /* Host request register */ #define MHI_SOC_RESET_REQ_OFFSET 0xb0