diff mbox series

[1/1] dt-bindings: PCI: layerscape-pci: Add deprecated property 'num-viewport'

Message ID 20240823185855.776904-1-Frank.Li@nxp.com (mailing list archive)
State Accepted
Delegated to: Krzysztof Wilczyński
Headers show
Series [1/1] dt-bindings: PCI: layerscape-pci: Add deprecated property 'num-viewport' | expand

Commit Message

Frank Li Aug. 23, 2024, 6:58 p.m. UTC
Copy the 'num-viewport' property from snps,dw-pcie-common.yaml to
fsl,layerscape-pcie.yaml to address the below warning. This is necessary
due to historical reasons where fsl,layerscape-pcie.yaml does not
directly reference snps,dw-pcie-common.yaml.

/arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: pcie@3400000: Unevaluated properties are not allowed ('num-viewport' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml      | 8 ++++++++
 1 file changed, 8 insertions(+)

--
2.34.1

Comments

Rob Herring Aug. 26, 2024, 2:04 p.m. UTC | #1
On Fri, 23 Aug 2024 14:58:54 -0400, Frank Li wrote:
> Copy the 'num-viewport' property from snps,dw-pcie-common.yaml to
> fsl,layerscape-pcie.yaml to address the below warning. This is necessary
> due to historical reasons where fsl,layerscape-pcie.yaml does not
> directly reference snps,dw-pcie-common.yaml.
> 
> /arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: pcie@3400000: Unevaluated properties are not allowed ('num-viewport' was unexpected)
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml      | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Frank Li Sept. 4, 2024, 1:59 p.m. UTC | #2
On Mon, Aug 26, 2024 at 09:04:53AM -0500, Rob Herring (Arm) wrote:
>
> On Fri, 23 Aug 2024 14:58:54 -0400, Frank Li wrote:
> > Copy the 'num-viewport' property from snps,dw-pcie-common.yaml to
> > fsl,layerscape-pcie.yaml to address the below warning. This is necessary
> > due to historical reasons where fsl,layerscape-pcie.yaml does not
> > directly reference snps,dw-pcie-common.yaml.
> >
> > /arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: pcie@3400000: Unevaluated properties are not allowed ('num-viewport' was unexpected)
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml      | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>

Bjorn and krzysztof wilczynaski

	Could you pick this trivial binding doc change patch, which acked
by Rob, I don't want to miss this merge windows. It help reduce
CHECK_DTBS warnings.

Frank

>
Krzysztof Wilczyński Sept. 4, 2024, 2:50 p.m. UTC | #3
Hello,

> Copy the 'num-viewport' property from snps,dw-pcie-common.yaml to
> fsl,layerscape-pcie.yaml to address the below warning. This is necessary
> due to historical reasons where fsl,layerscape-pcie.yaml does not
> directly reference snps,dw-pcie-common.yaml.
> 
> /arch/arm64/boot/dts/freescale/fsl-ls1012a-frwy.dtb: pcie@3400000: Unevaluated properties are not allowed ('num-viewport' was unexpected)

Applied to dt-bindings, thank you!

[1/1] dt-bindings: PCI: layerscape-pci: Add deprecated property 'num-viewport'
      https://git.kernel.org/pci/pci/c/b9fe09a1b293

	Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
index 2f79551f6083c..ea7aa8c83a553 100644
--- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml
@@ -71,6 +71,14 @@  properties:
     minItems: 1
     maxItems: 2

+  num-viewport:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    deprecated: true
+    description:
+      Number of outbound view ports configured in hardware. It's the same as
+      the number of outbound AT windows.
+    maximum: 256
+
 required:
   - compatible
   - reg