| Message ID | 20240827085739.3817877-1-yanzhen@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] spi: nxp-fspi: Use min macro | expand |
> -----Original Message----- > From: Yan Zhen <yanzhen@vivo.com> > Sent: 2024年8月27日 16:58 > To: Han Xu <han.xu@nxp.com>; Bough Chen <haibo.chen@nxp.com>; > broonie@kernel.org > Cc: yogeshgaur.83@gmail.com; linux-spi@vger.kernel.org; > linux-kernel@vger.kernel.org; opensource.kernel@vivo.com; Yan Zhen > <yanzhen@vivo.com> > Subject: [PATCH v1] spi: nxp-fspi: Use min macro > > When the original file is guaranteed to contain the minmax.h header file and > compile correctly, using the real macro is usually more intuitive and readable. > > Signed-off-by: Yan Zhen <yanzhen@vivo.com> > --- > drivers/spi/spi-nxp-fspi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index > 88397f712a3b..fda902aa5815 100644 > --- a/drivers/spi/spi-nxp-fspi.c > +++ b/drivers/spi/spi-nxp-fspi.c > @@ -756,8 +756,7 @@ static int nxp_fspi_read_ahb(struct nxp_fspi *f, const > struct spi_mem_op *op) > iounmap(f->ahb_addr); > > f->memmap_start = start; > - f->memmap_len = len > NXP_FSPI_MIN_IOMAP ? > - len : NXP_FSPI_MIN_IOMAP; > + f->memmap_len = max(len, NXP_FSPI_MIN_IOMAP); Reviewed-by: Haibo Chen <haibo.chen@nxp.com> Thanks! Haibo Chen > > f->ahb_addr = ioremap(f->memmap_phy + f->memmap_start, > f->memmap_len); > -- > 2.34.1
Hi, On Tue Aug 27, 2024 at 10:57 AM CEST, Yan Zhen wrote: > When the original file is guaranteed to contain the minmax.h header file > and compile correctly, using the real macro is usually > more intuitive and readable. The subject doesn't match what you're doing here. Also, shouldn't one use max_t()? -michael > > Signed-off-by: Yan Zhen <yanzhen@vivo.com> > --- > drivers/spi/spi-nxp-fspi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c > index 88397f712a3b..fda902aa5815 100644 > --- a/drivers/spi/spi-nxp-fspi.c > +++ b/drivers/spi/spi-nxp-fspi.c > @@ -756,8 +756,7 @@ static int nxp_fspi_read_ahb(struct nxp_fspi *f, const struct spi_mem_op *op) > iounmap(f->ahb_addr); > > f->memmap_start = start; > - f->memmap_len = len > NXP_FSPI_MIN_IOMAP ? > - len : NXP_FSPI_MIN_IOMAP; > + f->memmap_len = max(len, NXP_FSPI_MIN_IOMAP); > > f->ahb_addr = ioremap(f->memmap_phy + f->memmap_start, > f->memmap_len);
From: Michael Walle > Sent: 27 August 2024 12:58 > > Hi, > > On Tue Aug 27, 2024 at 10:57 AM CEST, Yan Zhen wrote: > > When the original file is guaranteed to contain the minmax.h header file > > and compile correctly, using the real macro is usually > > more intuitive and readable. > > The subject doesn't match what you're doing here. Also, shouldn't > one use max_t()? You should pretty much never use max_t(). Using it is just an accident waiting to happen. David > > -michael > > > > > Signed-off-by: Yan Zhen <yanzhen@vivo.com> > > --- > > drivers/spi/spi-nxp-fspi.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c > > index 88397f712a3b..fda902aa5815 100644 > > --- a/drivers/spi/spi-nxp-fspi.c > > +++ b/drivers/spi/spi-nxp-fspi.c > > @@ -756,8 +756,7 @@ static int nxp_fspi_read_ahb(struct nxp_fspi *f, const struct spi_mem_op *op) > > iounmap(f->ahb_addr); > > > > f->memmap_start = start; > > - f->memmap_len = len > NXP_FSPI_MIN_IOMAP ? > > - len : NXP_FSPI_MIN_IOMAP; > > + f->memmap_len = max(len, NXP_FSPI_MIN_IOMAP); > > > > f->ahb_addr = ioremap(f->memmap_phy + f->memmap_start, > > f->memmap_len); - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 88397f712a3b..fda902aa5815 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -756,8 +756,7 @@ static int nxp_fspi_read_ahb(struct nxp_fspi *f, const struct spi_mem_op *op) iounmap(f->ahb_addr); f->memmap_start = start; - f->memmap_len = len > NXP_FSPI_MIN_IOMAP ? - len : NXP_FSPI_MIN_IOMAP; + f->memmap_len = max(len, NXP_FSPI_MIN_IOMAP); f->ahb_addr = ioremap(f->memmap_phy + f->memmap_start, f->memmap_len);
When the original file is guaranteed to contain the minmax.h header file and compile correctly, using the real macro is usually more intuitive and readable. Signed-off-by: Yan Zhen <yanzhen@vivo.com> --- drivers/spi/spi-nxp-fspi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)