| Message ID | 20240826-net-mptcp-close-extra-sf-fin-v1-0-905199fe1172@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: close subflow when receiving TCP+FIN and misc. | expand |
On Mon, 26 Aug 2024 19:11:17 +0200 Matthieu Baerts (NGI0) wrote: > Matthieu Baerts (NGI0) (4): > mptcp: close subflow when receiving TCP+FIN > selftests: mptcp: join: cannot rm sf if closed > mptcp: sched: check both backup in retrans > mptcp: pr_debug: add missing \n at the end Why are you submitting two series to the same tree at once? The limit of 15 patches applies, no matter how you post.
On 27/08/2024 05:33, Jakub Kicinski wrote: > On Mon, 26 Aug 2024 19:11:17 +0200 Matthieu Baerts (NGI0) wrote: >> Matthieu Baerts (NGI0) (4): >> mptcp: close subflow when receiving TCP+FIN >> selftests: mptcp: join: cannot rm sf if closed >> mptcp: sched: check both backup in retrans >> mptcp: pr_debug: add missing \n at the end > > Why are you submitting two series to the same tree at once? > The limit of 15 patches applies, no matter how you post. Oh sorry, I didn't know about that. Recently, we queued a large amount of patches targetting the -net tree, blocking other patches queued for net-next for a few weeks now. Because the two series I sent yesterday were not related to each others, I thought it was OK to send them in parallel. But I understand the rate limit. I will wait to send the next patches. Cheers, Matt
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 26 Aug 2024 19:11:17 +0200 you wrote: > Here are different fixes: > > Patch 1 closes the subflow after having received a FIN, instead of > leaving it half-closed until the end of the MPTCP connection. A fix for > v5.12. > > Patch 2 validates the previous patch. > > [...] Here is the summary with links: - [net,1/4] mptcp: close subflow when receiving TCP+FIN https://git.kernel.org/netdev/net/c/f09b0ad55a11 - [net,2/4] selftests: mptcp: join: cannot rm sf if closed https://git.kernel.org/netdev/net/c/e93681afcb96 - [net,3/4] mptcp: sched: check both backup in retrans https://git.kernel.org/netdev/net/c/2a1f596ebb23 - [net,4/4] mptcp: pr_debug: add missing \n at the end https://git.kernel.org/netdev/net/c/cb41b195e634 You are awesome, thank you!
Here are different fixes: Patch 1 closes the subflow after having received a FIN, instead of leaving it half-closed until the end of the MPTCP connection. A fix for v5.12. Patch 2 validates the previous patch. Patch 3 is a fix for a recent fix to check both directions for the backup flag. It can follow the 'Fixes' commit and be backported up to v5.7. Patch 4 adds a missing \n at the end of pr_debug(), causing debug messages to be displayed with a delay, which confuses the debugger. A fix for v5.6. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Note: Peter's email address has been removed from the Cc list, because it is bouncing. --- Matthieu Baerts (NGI0) (4): mptcp: close subflow when receiving TCP+FIN selftests: mptcp: join: cannot rm sf if closed mptcp: sched: check both backup in retrans mptcp: pr_debug: add missing \n at the end net/mptcp/fastopen.c | 4 +- net/mptcp/options.c | 50 ++++++++++----------- net/mptcp/pm.c | 28 ++++++------ net/mptcp/pm_netlink.c | 20 ++++----- net/mptcp/protocol.c | 59 +++++++++++++------------ net/mptcp/protocol.h | 4 +- net/mptcp/sched.c | 4 +- net/mptcp/sockopt.c | 4 +- net/mptcp/subflow.c | 56 ++++++++++++----------- tools/testing/selftests/net/mptcp/mptcp_join.sh | 11 ++--- 10 files changed, 122 insertions(+), 118 deletions(-) --- base-commit: 31a972959ae57691a1e4f539399b2674ae576086 change-id: 20240826-net-mptcp-close-extra-sf-fin-19d4e5aa4c9c Best regards,