mbox series

[v2,0/2] Fix compatibles for RK3588 VO{0,1}_GRF

Message ID 20240828-rk3588-vo-grf-compat-v2-0-4db2f791593f@collabora.com (mailing list archive)
Headers show
Series Fix compatibles for RK3588 VO{0,1}_GRF | expand

Message

Cristian Ciocaltea Aug. 28, 2024, 12:40 p.m. UTC
As Conor noticed recently [1], RK3588 VO0 & VO1 GRFs incorrectly share
the compatible string, since they are not identical (though quite
similar in terms of layout).

Provide dedicated compatible strings, as a follow-up.

[1] https://lore.kernel.org/lkml/20240821-stretch-scam-09d7adc08a4c@spud/

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
Changes in v2:
- Deprecate the old compatible instead of removing it from the binding
  document (Krzysztof)
- Link to v1: https://lore.kernel.org/r/20240827-rk3588-vo-grf-compat-v1-0-d4a18acf951a@collabora.com

---
Cristian Ciocaltea (2):
      dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF
      arm64: dts: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF

 Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 10 +++++++++-
 arch/arm64/boot/dts/rockchip/rk3588-base.dtsi           |  6 +++---
 2 files changed, 12 insertions(+), 4 deletions(-)
---
base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
change-id: 20240827-rk3588-vo-grf-compat-4d2c84dc782b

Comments

Conor Dooley Aug. 28, 2024, 3:39 p.m. UTC | #1
On Wed, Aug 28, 2024 at 03:40:07PM +0300, Cristian Ciocaltea wrote:
> As Conor noticed recently [1], RK3588 VO0 & VO1 GRFs incorrectly share
> the compatible string, since they are not identical (though quite
> similar in terms of layout).
> 
> Provide dedicated compatible strings, as a follow-up.
> 
> [1] https://lore.kernel.org/lkml/20240821-stretch-scam-09d7adc08a4c@spud/
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Heiko Stübner Aug. 29, 2024, 11:55 a.m. UTC | #2
On Wed, 28 Aug 2024 15:40:07 +0300, Cristian Ciocaltea wrote:
> As Conor noticed recently [1], RK3588 VO0 & VO1 GRFs incorrectly share
> the compatible string, since they are not identical (though quite
> similar in terms of layout).
> 
> Provide dedicated compatible strings, as a follow-up.
> 
> [1] https://lore.kernel.org/lkml/20240821-stretch-scam-09d7adc08a4c@spud/
> 
> [...]

Applied, thanks!

[1/2] dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF
      commit: 11746c33909b082cb3b2183dd4164eb8bdcfc3df
[2/2] arm64: dts: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF
      commit: 5956ee09c8254273c587b07f5b4d42da59a0325c

Best regards,