| Message ID | 20240828203721.2751904-20-quic_nkela@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | arm64: qcom: Introduce SA8255p Ride platform | expand |
On Wed, Aug 28, 2024 at 01:37:18PM -0700, Nikunj Kela wrote: > Add compatible representing i2c support on SA8255p. > > Clocks and interconnects are being configured in Firmware VM > on SA8255p, therefore making them optional. > > CC: Praveen Talari <quic_ptalari@quicinc.com> > Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> > --- > .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 56 ++++++++++++------- > 1 file changed, 36 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > index 9f66a3bb1f80..88f513fc5b08 100644 > --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml > @@ -15,14 +15,13 @@ properties: > enum: > - qcom,geni-i2c > - qcom,geni-i2c-master-hub > + - qcom,sa8255p-geni-i2c Same as in other patches, this does not make sense. What is the point of generic compatibles? > > clocks: > - minItems: 1 > - maxItems: 2 Nope. > + description: phandles for the clock providers Useless description. This cannot be anything else than phandles for the clock providers. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml index 9f66a3bb1f80..88f513fc5b08 100644 --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-geni-qcom.yaml @@ -15,14 +15,13 @@ properties: enum: - qcom,geni-i2c - qcom,geni-i2c-master-hub + - qcom,sa8255p-geni-i2c clocks: - minItems: 1 - maxItems: 2 + description: phandles for the clock providers clock-names: - minItems: 1 - maxItems: 2 + description: names for the clocks clock-frequency: default: 100000 @@ -36,12 +35,13 @@ properties: - const: rx interconnects: - minItems: 2 - maxItems: 3 + description: phandles of interconnect bw provider interconnect-names: - minItems: 2 - maxItems: 3 + items: + - const: qup-core + - const: qup-config + - const: qup-memory interrupts: maxItems: 1 @@ -69,8 +69,6 @@ properties: required: - compatible - interrupts - - clocks - - clock-names - reg allOf: @@ -100,22 +98,28 @@ allOf: items: - const: qup-core - const: qup-config + - if: + properties: + compatible: + contains: + const: qcom,sa8255p-geni-i2c + then: + required: + - power-domains else: properties: clocks: - maxItems: 1 - + minItems: 1 + maxItems: 2 clock-names: - const: se - + minItems: 1 + maxItems: 2 interconnects: - minItems: 3 - + minItems: 2 + maxItems: 3 interconnect-names: - items: - - const: qup-core - - const: qup-config - - const: qup-memory + minItems: 2 + maxItems: 3 unevaluatedProperties: false @@ -143,4 +147,16 @@ examples: power-domains = <&rpmhpd SC7180_CX>; required-opps = <&rpmhpd_opp_low_svs>; }; + + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + i2c@a90000 { + compatible = "qcom,sa8255p-geni-i2c"; + reg = <0xa90000 0x4000>; + interrupts = <GIC_SPI 357 IRQ_TYPE_LEVEL_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + power-domains = <&scmi9_pd 11>; + }; ...
Add compatible representing i2c support on SA8255p. Clocks and interconnects are being configured in Firmware VM on SA8255p, therefore making them optional. CC: Praveen Talari <quic_ptalari@quicinc.com> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com> --- .../bindings/i2c/qcom,i2c-geni-qcom.yaml | 56 ++++++++++++------- 1 file changed, 36 insertions(+), 20 deletions(-)